Re: RFR [15/java.xml] 8237456: Transform filtered through SAX filter mishandles character entities

Thanks Aleksei, Lance! I'm using NetBeans, but I may get back to Intellij once my new machine arrives :-) -Joe On 6/9/2020 5:41 AM, Lance Andersen wrote: Hi Joe, This looks good. For your test,  Intellij typically suggests using a static import for Assert: —— import static

Re: RFR [15/java.xml] 8237456: Transform filtered through SAX filter mishandles character entities

Hi Joe, This looks good. For your test, Intellij typically suggests using a static import for Assert: —— import static org.testng.Assert.*; — No need to change but typically which get suggested when you run Inspect Code Best Lance > On Jun 9, 2020, at 1:54 AM, Joe Wang wrote:

Re: RFR [15/java.xml] 8237456: Transform filtered through SAX filter mishandles character entities

Hi Joe, The changes looks good to me. Best, Aleksei On 09/06/2020 06:54, Joe Wang wrote: Hi, Please review a fix to a regression that resulted in invalid output in a transform that contains entity references. The regression was caused by a JDK9 patch [1]. Adding back the conditional checks

RFR [15/java.xml] 8237456: Transform filtered through SAX filter mishandles character entities

Hi, Please review a fix to a regression that resulted in invalid output in a transform that contains entity references. The regression was caused by a JDK9 patch [1]. Adding back the conditional checks fixed the issue. JBS: https://bugs.openjdk.java.net/browse/JDK-8237456 webrevs: