On 2/25/20 8:01 AM, fo...@univ-mlv.fr wrote:
If the IOOBE is noise, it can be ignored.
You are forcing all primary users to ignore something that is useful only for
the secondary users.
Given that the ratio between primary vs secondary users is at least 100 000 for
1 if not more, that's a
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "Martin Buchholz" , "Kiran Ravikumar"
> , "core-libs-dev"
>
> Envoyé: Vendredi 21 Février 2020 22:53:36
> Objet: Re: RFR [15] 8161558: ListIterator sho
On 2/14/20 2:34 PM, fo...@univ-mlv.fr wrote:
The thing is that inside the iterator, you already have the right information,
so you don't have to pray to have the right info.
No, the iterator only can guess at the reason that get() threw the exception.
I just disagree on the conclusion,
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "Martin Buchholz" , "Kiran Ravikumar"
> , "core-libs-dev"
>
> Envoyé: Vendredi 14 Février 2020 18:25:14
> Objet: Re: RFR [15] 8161558: ListIterator sho
re-written to test the bound instead
of catching the IOOBE because i'm not sure this "optimization" make sense
nowadays.
regards,
Rémi
- Mail original -
De: "Kiran Ravikumar"
À: "core-libs-dev"
Envoyé: Mercredi 5 Février 2020 20:49:09
Objet: Re: RFR [15]
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "Martin Buchholz" , "Kiran Ravikumar"
> , "core-libs-dev"
>
> Envoyé: Mardi 11 Février 2020 00:57:52
> Objet: Re: RFR [15] 8161558: ListIterator s
Hi Kiran,
Thanks for reworking the test. This looks good to me. One small thing:
53 throw new IndexOutOfBoundsException();
This should include the offending index in the IOOBE. This might make Rémi
happy. (Then again, it might not.) :-)
I think this covers the concerns that
"Kiran Ravikumar"
À: "core-libs-dev"
Envoyé: Mercredi 5 Février 2020 20:49:09
Objet: Re: RFR [15] 8161558: ListIterator should not discard cause on exception
Thanks Stuart and Martin,
Here is an updated webrev with the changes.
http://cr.openjdk.java.net/~k
;
> À: "core-libs-dev"
> Envoyé: Mercredi 5 Février 2020 20:49:09
> Objet: Re: RFR [15] 8161558: ListIterator should not discard cause on
> exception
> Thanks Stuart and Martin,
>
>
> Here is an updated webrev with the changes.
>
> http://cr.openjdk.java.n
Thanks Stuart and Martin,
Here is an updated webrev with the changes.
http://cr.openjdk.java.net/~kravikumar/8161558/webrev.01/
JBS: https://bugs.openjdk.java.net/browse/JDK-8161558
Thanks,
Kiran
On 15/01/2020 12:46, Martin Buchholz wrote:
Hi Kiran,
Looks good to me, but I always
On 1/15/20 4:46 AM, Martin Buchholz wrote:
I would have documented whitebox test assumptions: that nCopies iterators
are implemented via AbstractList, and that AbstractList's list iterator
inherits behavior from iterator.
I probably would have added a plain iterator test, and might have
Hi Kiran,
Looks good to me, but I always nitpick ...
Stray semicolon?
var iterator = list.listIterator(list.size());; // position at end
I would have documented whitebox test assumptions: that nCopies iterators
are implemented via AbstractList, and that AbstractList's list iterator
Hi Guys,
Could someone please review my fix to add missing standard constructor
overloads to NoSuchElementException class and update the AbstractList
class to use them.
A CSR was filed and approved. Along with the code change a new test is
added to verify the behavior.
Please find the
13 matches
Mail list logo
