Looks good to me, thanks!
Kind regards,
Ivan
On 4/7/20 8:28 AM, Pavel Rappo wrote:
Hi Ivan,
On 7 Apr 2020, at 09:11, Ivan Gerasimov wrote:
Hi Pavel!
A couple of comments.
1)
java/util/logging/Formatter.java
This has one extra open curly brace:
"{{@literal }"
The leftmost curly brace
Hi Pavel,
On 4/7/2020 1:07 PM, Pavel Rappo wrote:
Thanks, Joe. I presume you mean me changing this
* {@code interface}
to this
* {@code @interface}
Correct.
Right? If so, then it renders the same way, and the `@interface` does not
confuse the Standard Doclet. After
Thanks, Joe. I presume you mean me changing this
* {@code interface}
to this
* {@code @interface}
Right? If so, then it renders the same way, and the `@interface` does not
confuse the Standard Doclet. After JDK-8241780 "Allow \n@ inside inline tags"
has been done and dusted we'll never
Hi Pavel,
Looks fine in general, assuming the change to Class.java renders
correctly in output.
Thanks,
-Joe
On 4/7/2020 8:28 AM, Pavel Rappo wrote:
Hi Ivan,
On 7 Apr 2020, at 09:11, Ivan Gerasimov wrote:
Hi Pavel!
A couple of comments.
1)
java/util/logging/Formatter.java
This has
Hi Ivan,
On 07/04/2020 09:11, Ivan Gerasimov wrote:
1)
java/util/logging/Formatter.java
This has one extra open curly brace:
"{{@literal }"
That one looks like a typo but is not a typo.
It means: if the string contains "{0" or "{1" or ...
cheers,
-- daniel
Hi Ivan,
> On 7 Apr 2020, at 09:11, Ivan Gerasimov wrote:
>
> Hi Pavel!
>
> A couple of comments.
>
> 1)
> java/util/logging/Formatter.java
>
> This has one extra open curly brace:
>
> "{{@literal }"
The leftmost curly brace is not a part of the "literal" inline tag, but rather
a part of
Hi Pavel!
A couple of comments.
1)
java/util/logging/Formatter.java
This has one extra open curly brace:
"{{@literal }"
2)
grep finds some more typos of the same kind that you've spotted.
a) rgrep '^[ ]*\*'|grep ' ,'|less
This find number of potential typos. For example, the javadoc for
Hello,
Please review the change for https://bugs.openjdk.java.net/browse/JDK-8242230:
http://cr.openjdk.java.net/~prappo/8242230/webrev.00/
This is a documentation cleanup. There are no code changes involved,
and the changes in documentation are mostly trivial.
The following packages are
