Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-18 Thread Joe Wang
:* Mark Sheppard *Subject:* Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Thanks Mark! I missed that, and I was also 20 min too fast on the checkin :-) Here's a catch-up patch, pls review: http://cr.openjdk.java.net/~joehw/jdk15/8245231/w

Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-18 Thread mark sheppard
To: core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> <mailto:core-libs-dev@openjdk.java.net> Subject: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi, Please review a fix for the compilation warnings. Thanks Roger for

Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-18 Thread Joe Wang
44342: Compilation warnings about unexpected serialization related method signatures. Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test p

Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-18 Thread mark sheppard
Subject: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too

Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-18 Thread Roger Riggs
Hi Joe, Looks good, thanks for the cleanup. Roger On 5/15/20 2:39 PM, naoto.s...@oracle.com wrote: +1 Naoto On 5/15/20 11:35 AM, Lance Andersen wrote: Looks ok joe On May 15, 2020, at 1:54 PM, Joe Wang wrote: Hi, Please review a fix for the compilation warnings. Thanks Roger for the

Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-15 Thread naoto . sato
+1 Naoto On 5/15/20 11:35 AM, Lance Andersen wrote: Looks ok joe On May 15, 2020, at 1:54 PM, Joe Wang wrote: Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be g

Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-15 Thread Lance Andersen
Looks ok joe > On May 15, 2020, at 1:54 PM, Joe Wang wrote: > > Hi, > > Please review a fix for the compilation warnings. Thanks Roger for the > detailed instructions! If you could verify the fix with the work-in-progress > processor, that would be great too. Regular build and test passed. >

RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.

2020-05-15 Thread Joe Wang
Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed. https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.n