Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread Ivan Gerasimov
Thank you Mandy! Seems like I managed to skip the mailing lists when sending the 3rd version of the review. Sorry about that. Sincerely yours, Ivan On 09.10.2014 9:56, Mandy Chung wrote: http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/ I reviewed v3 version. Looks good. Mandy

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread Mandy Chung
http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/ I reviewed v3 version. Looks good. Mandy

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread Ivan Gerasimov
Thanks Mandy! Nit: I suggest to remove the directory "a" at the beginning rather than throwing a RuntimeException so that you can run the test multiple times manually. Yes, makes sense. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8059563/2/webrev/ Sincerely yours, Ivan

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread Mandy Chung
On 10/7/2014 1:47 AM, Ivan Gerasimov wrote: Thank you Mandy! I've updated the webrev based on your suggestions. The test is moved to test/sun/misc/ProxyGenerator/ directory. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8059563/1/webrev/ Thanks for updating the test. Nit:

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-07 Thread Ivan Gerasimov
Thank you Mandy! I've updated the webrev based on your suggestions. The test is moved to test/sun/misc/ProxyGenerator/ directory. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8059563/1/webrev/ Sincerely yours, Ivan On 07.10.2014 9:47, Mandy Chung wrote: On 10/6/2014 4:35 A

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-06 Thread Mandy Chung
On 10/6/2014 4:35 AM, Ivan Gerasimov wrote: Hello! This is a 7u-only fix. Some users complain about the ProxyGenerator not creating the intermediate directories when asked to keep the generated files. It throws an IO exception instead The fix is essentially a part of JDK-8004260. That was a

RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-06 Thread Ivan Gerasimov
Hello! This is a 7u-only fix. Some users complain about the ProxyGenerator not creating the intermediate directories when asked to keep the generated files. It throws an IO exception instead The fix is essentially a part of JDK-8004260. That was a relatively big update, which required CCC, so