Re: RFR [9] 8145589: Test6277246.java fails to compile after JDK-8144479

2015-12-18 Thread Sergey Bylokhov
Looks fine. On 17/12/15 18:28, Roger Riggs wrote: +1 On 12/17/2015 10:15 AM, Chris Hegarty wrote: For ease of review, I moved the complete changes into a webrev. http://cr.openjdk.java.net/~chegar/8145589/webrev/ -Chris. On 17 Dec 2015, at 15:08, Chris Hegarty

RFR [9] 8145589: Test6277246.java fails to compile after JDK-8144479

2015-12-17 Thread Chris Hegarty
The removal of BASE64Encoder, and a related types, in 8144479 [1] has triggered the failure of java/beans/Introspector/Test6277246.java. Another internal type should be used instead of sun.misc.BASE64Encoder. The sun.security.x509 package seems stable, and is being used in other areas, like

Re: RFR [9] 8145589: Test6277246.java fails to compile after JDK-8144479

2015-12-17 Thread Roger Riggs
Hi Chris, Looks fine. Roger On 12/17/2015 9:46 AM, Chris Hegarty wrote: The removal of BASE64Encoder, and a related types, in 8144479 [1] has triggered the failure of java/beans/Introspector/Test6277246.java. Another internal type should be used instead of sun.misc.BASE64Encoder. The

Re: RFR [9] 8145589: Test6277246.java fails to compile after JDK-8144479

2015-12-17 Thread Chris Hegarty
On 17 Dec 2015, at 14:54, Roger Riggs wrote: > Hi Chris, > > Looks fine. Thanks Roger. Just a little addition to this review. While not strictly necessary, I’d like to clean up another, string, reference use in a reflective call. ( It is not causing a failure as the

Re: RFR [9] 8145589: Test6277246.java fails to compile after JDK-8144479

2015-12-17 Thread Chris Hegarty
For ease of review, I moved the complete changes into a webrev. http://cr.openjdk.java.net/~chegar/8145589/webrev/ -Chris. On 17 Dec 2015, at 15:08, Chris Hegarty wrote: > On 17 Dec 2015, at 14:54, Roger Riggs wrote: > >> Hi Chris, >> >>

Re: RFR [9] 8145589: Test6277246.java fails to compile after JDK-8144479

2015-12-17 Thread Roger Riggs
+1 On 12/17/2015 10:15 AM, Chris Hegarty wrote: For ease of review, I moved the complete changes into a webrev. http://cr.openjdk.java.net/~chegar/8145589/webrev/ -Chris. On 17 Dec 2015, at 15:08, Chris Hegarty wrote: On 17 Dec 2015, at 14:54, Roger Riggs