The langtools test changes look OK. I investigated TestRecordTypes.java
a bit because of the "jdk11" component in the file name, but the changes
look OK, and there is caveat text in the test itself to indicate the
file should be updated at some point to a more recent version anyway.
-- Jon
O
Thank you Roger for the additional changes.
Looks good.
Please remember to update the copyright year for jdk/TEST.groups and
hotspot tests before push, and fix the changed year in
bin/unshuffle_list.txt (missed a `,` after 2020)
(I'm not an official reviewer.)
Thanks,
Amy
On 4/6/20 11:25
On 03/04/2020 16:43, Roger Riggs wrote:
Please review the CSR[1] and changes to remove the RMI static stub
compiler (rmic).
RMIC was deprecated for removal in JDK 13 [3].
The components modified are:
- remove the jdk.rmic module
- remove the jdk.rmic man page
- remove all tests of rmic or
Hi Amy,
Thanks for looking in places I didn't grep for rmic references.
Hotspot for cds and langtools for javadoc.
The webrev is covers just the new changes but I will merge them before
the push.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc/
Thanks, Roger
On 4
Hi, Roger
I noticed some other minor cleanup needed, will they be included in this
fix, or separately in the future?
1. test/jdk/TEST.groups
To remove `sun/tools/java` from core_tools and svc_tools group. (The
only one test under `sun/tools/java` got removed in this patch.)
2. doc/building.
Looks good.
/Erik
On 2020-04-03 08:43, Roger Riggs wrote:
Please review the CSR[1] and changes to remove the RMI static stub
compiler (rmic).
RMIC was deprecated for removal in JDK 13 [3].
The components modified are:
- remove the jdk.rmic module
- remove the jdk.rmic man page
- remove all
Hi Roger,
This looks good and brought back memories of removing the Java EE modules :-)
Best
Lance
> On Apr 3, 2020, at 11:43 AM, Roger Riggs wrote:
>
> Please review the CSR[1] and changes to remove the RMI static stub compiler
> (rmic).
> RMIC was deprecated for removal in JDK 13 [3].
>
>
Please review the CSR[1] and changes to remove the RMI static stub
compiler (rmic).
RMIC was deprecated for removal in JDK 13 [3].
The components modified are:
- remove the jdk.rmic module
- remove the jdk.rmic man page
- remove all tests of rmic or relying on rmic
- update or remove makefil
