Re: RFR 6303183: Support NTFS and Unix-style timestamps for entries in Zip files

2013-05-29 Thread Xueming Shen
Hi Martin, Somehow most of your comments are blank lines in my mailbox, just wonder if you can send them again. Based on the hints, I updated those javadoc comments in ZipUtils to **. The code has been updated slightly (mainly to not output the extra time stamp if it already exists in the

Re: RFR 6303183: Support NTFS and Unix-style timestamps for entries in Zip files

2013-05-29 Thread Martin Buchholz
On Wed, May 29, 2013 at 3:17 PM, Xueming Shen xueming.s...@oracle.comwrote: Hi Martin, Somehow most of your comments are blank lines in my mailbox, just wonder if you can send them again. Based on the hints, I updated those javadoc comments in ZipUtils to **. Sorry, my mail program is a

Re: RFR 6303183: Support NTFS and Unix-style timestamps for entries in Zip files

2013-05-28 Thread Martin Buchholz
Looks good to me. --- While you're moving code around, you could fix the typo below and change method comments to javadoc style ('*' = '**'') accidnetly and

Re: RFR 6303183: Support NTFS and Unix-style timestamps for entries in Zip files

2013-05-25 Thread Alan Bateman
On 24/05/2013 23:53, Martin Buchholz wrote: Thanks very much for adding this support. Users will be happy. You could make it clearer in the javadoc that you are storing and returning times in seconds since the epoch, and that the epoch is Jan 1, 1980. Note that we now have both kinds of

Re: RFR 6303183: Support NTFS and Unix-style timestamps for entries in Zip files

2013-05-24 Thread Martin Buchholz
Thanks very much for adding this support. Users will be happy. You could make it clearer in the javadoc that you are storing and returning times in seconds since the epoch, and that the epoch is Jan 1, 1980. Note that we now have both kinds of epochs: 1970 and 1980, for extra confusion. Also, I