Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-23 Thread Ivan Gerasimov
Thank you Alan! On 5/23/19 11:35 AM, Alan Bateman wrote: On 23/05/2019 19:25, Ivan Gerasimov wrote: Hello! Do you think it's good to go now? Thanks in advance, This version looks okay to me. -Alan -- With kind regards, Ivan Gerasimov

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-23 Thread Alan Bateman
On 23/05/2019 19:25, Ivan Gerasimov wrote: Hello! Do you think it's good to go now? Thanks in advance, This version looks okay to me. -Alan

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-23 Thread Ivan Gerasimov
Hello! Do you think it's good to go now? Thanks in advance, Ivan On 5/20/19 12:26 PM, Ivan Gerasimov wrote: Thank you Jon and Alan for your suggestions! Here's the new webrev updated accordingly: http://cr.openjdk.java.net/~igerasim/7061590/01/webrev/ With kind regards, Ivan On 5/20/19

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-20 Thread Ivan Gerasimov
Thank you Jon and Alan for your suggestions! Here's the new webrev updated accordingly: http://cr.openjdk.java.net/~igerasim/7061590/01/webrev/ With kind regards, Ivan On 5/20/19 12:03 PM, Alan Bateman wrote: On 20/05/2019 19:48, Ivan Gerasimov wrote: Hello! A few small javadoc issues. T

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-20 Thread Alan Bateman
On 20/05/2019 19:48, Ivan Gerasimov wrote: Hello! A few small javadoc issues. The most visible one is that the last dot in abbreviation a.k.a. is treated as a period, so the generated description appears broken (see [1]

Re: RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-20 Thread Jonathan Gibbons
Ivan, You would do better to avoid the use of the shorthand "a.k.a." which may not be known to many readers.  In general, the style should be to avoid abbreviations like this, including e.g. i.e. etc. (sic) I recommend replacing "a.k.a." with "also known as:. -- Jon On 05/20/2019 11:48 AM,

RFR 7061590 : Javadoc issues in Charset and StandardCharsets

2019-05-20 Thread Ivan Gerasimov
Hello! A few small javadoc issues. The most visible one is that the last dot in abbreviation a.k.a. is treated as a period, so the generated description appears broken (see [1] ): static Cha