Helo,
I need a Reviewer for the following patch:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.05/
This fixes deadlock situation described in bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122142
The in-depth evaluation of the patch is described in the introd
dress it (using memoization pattern
that installs a Future for the AnnotationType).
Thanks,
David
*From: *Peter Levart mailto:peter.lev...@gmail.com>>
*Subject: **RFR 7122142 : (ann) Race condition between
isAnnotationPresent and getAnnotations*
*Date: *8 juli 2013 22:54:12 CEST
*To:
Hi, Peter,
Not a reviewer, and have barely any time to have the careful review, so
just a few nitpicks below:
On 07/09/2013 12:54 AM, Peter Levart wrote:
> http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.05/
AnnotationParser.java:
- Do you want make contains() generic?
s
e).
Thanks,
David
*From: *Peter Levart mailto:peter.lev...@gmail.com>>
*Subject: **RFR 7122142 : (ann) Race condition between
isAnnotationPresent and getAnnotations*
*Date: *8 juli 2013 22:54:12 CEST
*To: *Joel Borggrén-Franck mailto:joel.fra...@oracle.com>>
*Cc: *Alan Bateman m
On 07/15/2013 11:04 AM, Aleksey Shipilev wrote:
Hi, Peter,
Not a reviewer, and have barely any time to have the careful review, so
just a few nitpicks below:
On 07/09/2013 12:54 AM, Peter Levart wrote:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.05/
AnnotationParser.java
Levart >><mailto:peter.lev...@gmail.com>>
> >>*Subject: **RFR 7122142 : (ann) Race condition between
> >>isAnnotationPresent and getAnnotations*
> >>*Date: *8 juli 2013 22:54:12 CEST
> >>*To: *Joel Borggrén-Franck >><mailto:joel.fra...
On 07/15/2013 04:36 PM, Peter Levart wrote:
> I was guided by the Collection.contains() signature:
>
> Collection {
> boolean contains(Object o);
Dunno. This was done for compatibility with non-generic code. In your
code, you seem always know the type of the argument, it does not bother
me to
AnnotationType).
Thanks,
David
*From: *Peter Levart mailto:peter.lev...@gmail.com>>
*Subject: **RFR 7122142 : (ann) Race condition between
isAnnotationPresent and getAnnotations*
*Date: *8 juli 2013 22:54:12 CEST
*To: *Joel Borggrén-Franck mailto:joel.fra...@oracle.com>>
*Cc: *Al
Hi all,
I would like to ask for a review of combined back port for 7u-dev/7u80.
The main goal is to have a fix for 7122142 in jdk7, it also integrates
the changes from 8005232, 7185456, 8022721
https://bugs.openjdk.java.net/browse/JDK-7122142
https://bugs.openjdk.java.net/browse/JDK-8005232
h
Hi Dmeetry,
On 02/22/2014 01:22 PM, dmeetry degrave wrote:
Hi all,
I would like to ask for a review of combined back port for
7u-dev/7u80. The main goal is to have a fix for 7122142 in jdk7, it
also integrates the changes from 8005232, 7185456, 8022721
https://bugs.openjdk.java.net/browse/J
Thanks for looking at this, Peter!
On 02/24/2014 04:42 PM, Peter Levart wrote:
Hi Dmeetry,
On 02/22/2014 01:22 PM, dmeetry degrave wrote:
Hi all,
I would like to ask for a review of combined back port for
7u-dev/7u80. The main goal is to have a fix for 7122142 in jdk7, it
also integrates the
Hi,
I looked at webrev.1. Looks good.
cheers
/Joel
On 2014-02-25, dmeetry degrave wrote:
> Thanks for looking at this, Peter!
>
> On 02/24/2014 04:42 PM, Peter Levart wrote:
> >Hi Dmeetry,
> >
> >On 02/22/2014 01:22 PM, dmeetry degrave wrote:
> >>Hi all,
> >>
> >>I would like to ask for a revie
Hi all,
I would like to ask someone with a reviewer status in jdk7u project to
look at these changes.
thanks,
dmeetry
On 02/27/2014 05:44 PM, Joel Borggren-Franck wrote:
Hi,
I looked at webrev.1. Looks good.
cheers
/Joel
On 2014-02-25, dmeetry degrave wrote:
Thanks for looking at this, P
Looks fine to me as well.
cheers,
dalibor topic
On 3/3/14 1:21 PM, dmeetry degrave wrote:
> Hi all,
>
> I would like to ask someone with a reviewer status in jdk7u project to look
> at these changes.
>
> thanks,
> dmeetry
>
> On 02/27/2014 05:44 PM, Joel Borggren-Franck wrote:
>> Hi,
>>
>> I
14 matches
Mail list logo
