On 4/30/13 2:02 PM, Xueming Shen wrote:
I'm planning to push them in one changeset, if both get approved.
http://cr.openjdk.java.net/~sherman/8013254/webrev/
These 2 bugs are not dependent on each other as I understand. Is there
a reason why you want to push them in one single changeset bes
On 04/30/2013 01:58 PM, Mandy Chung wrote:
On 4/30/13 1:22 PM, Xueming Shen wrote:
updated webrev:
http://cr.openjdk.java.net/~sherman/8013252/webrev/
Looks good.
(again, the RegExTest.java is mixed with the change for
#8013254)
Are you going to separate the change in the right changeset?
On 4/30/13 1:22 PM, Xueming Shen wrote:
updated webrev:
http://cr.openjdk.java.net/~sherman/8013252/webrev/
Looks good.
(again, the RegExTest.java is mixed with the change for
#8013254)
Are you going to separate the change in the right changeset? I can't
find the webrev for 8013254 from y
On 04/30/2013 12:43 PM, Mandy Chung wrote:
Hi Sherman,
Looks okay in general. A couple of comments:
Have you considered providing a method to map from group name to its group
index? Would that be useful?
No plan for now. It appears a bit of redundant after we have the
start/end/group(name
Hi Sherman,
Looks okay in general. A couple of comments:
Have you considered providing a method to map from group name to its
group index? Would that be useful?
group(String) can simply return group(getMatchedGroupIndex(name)) rather
than duplicating the implementation. Similarly for star
Hi,
The regex named capturing group support was added into jdk7 [1].
Matcher.group(gname) is the only direct access method we added back then
to access the matched result. The proposed change here is to add a pair of
accessing/convenient method Matcher.start/end(gname) to access the start/end
off
