Looks fine. Thanks, Roger
On 10/20/2014 4:25 PM, Ivan Gerasimov wrote:
Thank you Roger!
Yes, you're right.
Please find the updated webrev here:
http://cr.openjdk.java.net/~igerasim/8023173/2/webrev/
Sincerely yours,
Ivan
On 20.10.2014 17:20, roger riggs wrote:
Hi Ivan,
This webrev appear
Thank you Roger!
Yes, you're right.
Please find the updated webrev here:
http://cr.openjdk.java.net/~igerasim/8023173/2/webrev/
Sincerely yours,
Ivan
On 20.10.2014 17:20, roger riggs wrote:
Hi Ivan,
This webrev appears removes the ability to interpose on various method
using byte-code inject
Hi Ivan,
This webrev appears removes the ability to interpose on various method
using byte-code injection. For example, FileOutputStream.write(byte).
Do *not *replace delete the Java method calls that call native.
It looks like an optimization but disables some functions that allow
monitoring
Thank you Alan for the review!
On 17.10.2014 13:00, Alan Bateman wrote:
On 06/10/2014 11:41, Ivan Gerasimov wrote:
Hello everybody!
The append mode is emulated on Windows, therefore we have to keep a
flag indicating that.
With the current implementation, the FileDescriptor does not know if
On 06/10/2014 11:41, Ivan Gerasimov wrote:
Hello everybody!
The append mode is emulated on Windows, therefore we have to keep a
flag indicating that.
With the current implementation, the FileDescriptor does not know if
the file were opened with O_APPEND, and the flag is maintained at the
up
Thanks for tackling this difficult area!
Alan is the most qualified to review, but I'll throw in some comments.
The title of the bug in jira doesn't match the one in the webrev - they
should be the same.
I'm not sure, but it looks like getAppend is called even on non-Windows
platforms, but there
Hello everybody!
The append mode is emulated on Windows, therefore we have to keep a flag
indicating that.
With the current implementation, the FileDescriptor does not know if the
file were opened with O_APPEND, and the flag is maintained at the upper
level.
This can cause inconsistency, whe
