RFR 8029452: Fork/Join task ForEachOps.ForEachOrderedTask clarifications and minor improvements

2014-01-10 Thread Paul Sandoz
Hi, Some tweaks to the Stream forEachOrdered operation: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8029452-ForEachOrdered/webrev/ The first tweak is to size the CHM used in ForEachOrderedTask, this avoids concurrent resizes and the costs associated with those. The second tweak is to consol

Re: RFR 8029452: Fork/Join task ForEachOps.ForEachOrderedTask clarifications and minor improvements

2014-01-10 Thread Mike Duigou
On Jan 10 2014, at 05:42 , Paul Sandoz wrote: > Hi, > > Some tweaks to the Stream forEachOrdered operation: > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8029452-ForEachOrdered/webrev/ > > The first tweak is to size the CHM used in ForEachOrderedTask, this avoids > concurrent resizes and

Re: RFR 8029452: Fork/Join task ForEachOps.ForEachOrderedTask clarifications and minor improvements

2014-01-10 Thread Paul Sandoz
On Jan 10, 2014, at 7:11 PM, Mike Duigou wrote: >> >> The second tweak is to consolidate the reporting of elements to within the >> ForEachOrderedTask.tryComplete method. >> >> I have also removed the inconsistently applied synchronized block. Either we >> apply it consistently to reporting o

Re: RFR 8029452: Fork/Join task ForEachOps.ForEachOrderedTask clarifications and minor improvements

2014-01-16 Thread Paul Sandoz
On Jan 10, 2014, at 2:42 PM, Paul Sandoz wrote: > I have also removed the inconsistently applied synchronized block. Either we > apply it consistently to reporting or not at all. It was originally there > because we were not sure that the "happens-before" relationship [1] between > elements wo

Re: RFR 8029452: Fork/Join task ForEachOps.ForEachOrderedTask clarifications and minor improvements

2014-01-16 Thread Mike Duigou
Very helpful. Thank you for adding the comments. Mike On Jan 16 2014, at 03:26 , Paul Sandoz wrote: > > On Jan 10, 2014, at 2:42 PM, Paul Sandoz wrote: >> I have also removed the inconsistently applied synchronized block. Either we >> apply it consistently to reporting or not at all. It was