On Jul 7, 2014, at 1:07 PM, Peter Levart wrote:
> Hi Pavel, Alan and Paul,
>
> Thanks for reviewing. I accepted the suggestions from Pavel and Paul and
> created webrev.02:
>
> http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/
>
> Is this good to go into jdk9-dev?
>
Looks
On 07/07/2014 12:07, Peter Levart wrote:
Hi Pavel, Alan and Paul,
Thanks for reviewing. I accepted the suggestions from Pavel and Paul
and created webrev.02:
http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/
Is this good to go into jdk9-dev?
The comments looks okay to me (a
Hi Pavel, Alan and Paul,
Thanks for reviewing. I accepted the suggestions from Pavel and Paul and
created webrev.02:
http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/
Is this good to go into jdk9-dev?
Regards, Peter
On 07/04/2014 04:54 PM, Paul Sandoz wrote:
On Jul 3, 20
On Jul 3, 2014, at 6:33 PM, Alan Bateman wrote:
> On 03/07/2014 09:43, Peter Levart wrote:
>> Hi,
>>
>> I noticed a data race in java.net.URL:
>>
>>https://bugs.openjdk.java.net/browse/JDK-8049220
>>
>> I propose the following simple patch:
>>
>> http://cr.openjdk.java.net/~plevart/jdk9-de
On 03/07/2014 09:43, Peter Levart wrote:
Hi,
I noticed a data race in java.net.URL:
https://bugs.openjdk.java.net/browse/JDK-8049220
I propose the following simple patch:
http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.01/
A good catch and the change looks good to me. I
Hi Peter,
Just a minor subjective issue. I would suggest changing the name of the local
variable 'factory' in java.net.URL.getURLStreamHandler method for something
different. It's a bit hard to read the code since this variable clashes with
the same-name class field.
Thanks,
-Pavel
On 3 Jul 2
Hi,
I noticed a data race in java.net.URL:
https://bugs.openjdk.java.net/browse/JDK-8049220
I propose the following simple patch:
http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.01/
Regards, Peter
