Re: RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-05 Thread Paul Sandoz
On Jun 5, 2015, at 12:57 AM, Stefan Zobel wrote: > With respect to the 'stream test library not closing streams' bug: > > would you mind to create a separate bugtracker issue for that, or do you > think it's too special to carry that weight? > Not too special just more more work than necessar

Re: RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-04 Thread Stefan Zobel
With respect to the 'stream test library not closing streams' bug: would you mind to create a separate bugtracker issue for that, or do you think it's too special to carry that weight? Thanks, Stefan 2015-06-04 22:06 GMT+02:00 Paul Sandoz : > On Jun 3, 2015, at 6:18 PM, Alan Bateman wrote: >

Re: RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-04 Thread Paul Sandoz
On Jun 3, 2015, at 6:18 PM, Alan Bateman wrote: > As this code path is only for the default provider case then there's a good > chance that it will be a FileChannelImpl, in which case you can call its > unmap method (directly or via a shared secret). It is possible to interpose > on the default

Re: RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-03 Thread Paul Sandoz
On Jun 3, 2015, at 9:19 PM, Xueming Shen wrote: > On 06/03/2015 08:53 AM, Paul Sandoz wrote: >> Hi, >> >> Please review an optimization for Files.lines for certain charsets: >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072773-File-lines/webrev/ >> >> If a charset is say US-ASCII or UT

Re: RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-03 Thread Xueming Shen
On 06/03/2015 08:53 AM, Paul Sandoz wrote: Hi, Please review an optimization for Files.lines for certain charsets: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072773-File-lines/webrev/ If a charset is say US-ASCII or UTF-8 it is possible to implement an efficient splitting Spliterator th

Re: RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-03 Thread Alan Bateman
On 03/06/2015 16:53, Paul Sandoz wrote: Hi, Please review an optimization for Files.lines for certain charsets: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072773-File-lines/webrev/ If a charset is say US-ASCII or UTF-8 it is possible to implement an efficient splitting Spliterator that

RFR 8072773 (fs) Files.lines needs a better splitting implementation for stream source

2015-06-03 Thread Paul Sandoz
Hi, Please review an optimization for Files.lines for certain charsets: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072773-File-lines/webrev/ If a charset is say US-ASCII or UTF-8 it is possible to implement an efficient splitting Spliterator that scans bytes from a mid-point to search for