> On 10 Jan 2017, at 08:36, Felix Yang wrote:
>
> Hi Paul,
> thanks for the comments. Please review the updated patch. About JJS
> testing, I’m not really aware of Nashorn codes but just help to implement the
> designed one. Andrey may comment more. In my opinion, it looks to be a
> reas
Hi Paul,
thanks for the comments. Please review the updated patch. About JJS
testing, I’m not really aware of Nashorn codes but just help to implement the
designed one. Andrey may comment more. In my opinion, it looks to be a
reasonable use case from functional aspect.
Webrev: http://cr.op
Hi Felix,
Generally looks good.
RuntimeTest
—
78 @BeforeTest
79 protected void setUpTest() throws Throwable {
Can you use @BeforeClass? since i believe the jar files only need to be created
once for all tests.
(And i presume it just overwrites any existing files that were previous
Hi there,
please review the following new tests to check runtime usage with
Multi-Release jars.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8075884
Webrev:
http://cr.openjdk.java.net/~xiaofeya/8075884/webrev.00/
Thanks,
Felix
