Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-14 Thread Alan Bateman
On 07/12/2015 19:38, Mike Dever Google wrote: Is there a work around? That really limits, actually kills a lot of functionality. The JDK 7 and JDK 8 builds don't declare AppleScript in the services configuration file (META-INF/services/javax.script.ScriptEngineFactory). This means that if yo

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-11 Thread Mike Dever Google
Is there a work around? That really limits, actually kills a lot of functionality.

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-07 Thread Mandy Chung
On 12/06/2015 07:17 PM, Sundararajan Athijegannathan wrote: Hi, Please review the updated webrevs http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.01/ http://cr.openjdk.java.net/~sundar/8143404/top/webrev.01/ http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/ Looks good.

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-07 Thread Alan Bateman
On 07/12/2015 03:17, Sundararajan Athijegannathan wrote: Hi, Please review the updated webrevs http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.01/ http://cr.openjdk.java.net/~sundar/8143404/top/webrev.01/ http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/ Updated patches l

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-06 Thread Sundararajan Athijegannathan
Hi, Please review the updated webrevs http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.01/ http://cr.openjdk.java.net/~sundar/8143404/top/webrev.01/ http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/ Thanks, -Sundar On 12/4/2015 12:12 PM, Mandy Chung wrote: Right. Run this

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-03 Thread Mandy Chung
Right. Run this on your repo after removing applescript $ jdeps $BUILD_OUTPUTDIR/jdk/modules/jdk.deploy.os You will see the dependency. It’s okay to remain the qualified exports. But you should remove the dependency on java.desktop and java.scripting. >> jdk/make/lib/Lib-jdk.deploy.osx.g

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-03 Thread Sundararajan Athijegannathan
I'm only removing applescript code. Not all of jdk.deploy.osx code (collection etc). Not sure if jdk.deploy.osx dependencies can be completely removed (yet). Removal of the other stuff has to be another bug. I'll update for other stuff you mentioned. -Sundar On 12/4/2015 9:01 AM, Mandy Chung

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-03 Thread Mandy Chung
> On Dec 3, 2015, at 5:41 PM, Sundararajan Athijegannathan > wrote: > > Hi, > > Thanks. Updated: > > http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.00/ > http://cr.openjdk.java.net/~sundar/8143404/top/webrev.00/ > http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/ > jdk/

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-03 Thread Sundararajan Athijegannathan
Hi, Thanks. Updated: http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.00/ http://cr.openjdk.java.net/~sundar/8143404/top/webrev.00/ http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/ Thanks, -Sundar On 12/3/2015 9:12 PM, Alan Bateman wrote: On 03/12/2015 15:06, Sundararaja

Re: RFR 8143404: Remove apple script engine code in jdk repository

2015-12-03 Thread Alan Bateman
On 03/12/2015 15:06, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8143404 Webrev: http://cr.openjdk.java.net/~sundar/8143404/webrev.00/ Apple script engine implementing javax.script engine API is being removed. AppleScript engine has flip f

RFR 8143404: Remove apple script engine code in jdk repository

2015-12-03 Thread Sundararajan Athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8143404 Webrev: http://cr.openjdk.java.net/~sundar/8143404/webrev.00/ Apple script engine implementing javax.script engine API is being removed. AppleScript engine has flip flopped between working and broken many times.The services c