Re: RFR 8152645 VarHandle lookup access control tests

> On 11 Apr 2016, at 13:02, Claes Redestad wrote: > > On 2016-04-11 12:03, Paul Sandoz wrote: >>> On 8 Apr 2016, at 15:37, Michael Haupt wrote: >>> >>> Hi Paul, >>> >>> note this is a lower-case review. Thumbs up. >>> >>> I like how the test lucidly documents the access rules, and would appl

Re: RFR 8152645 VarHandle lookup access control tests

On 2016-04-11 12:03, Paul Sandoz wrote: On 8 Apr 2016, at 15:37, Michael Haupt wrote: Hi Paul, note this is a lower-case review. Thumbs up. I like how the test lucidly documents the access rules, and would applaud an extended test that additionally covers module boundaries. +1 Just as a

Re: RFR 8152645 VarHandle lookup access control tests

> On 8 Apr 2016, at 15:37, Michael Haupt wrote: > > Hi Paul, > > note this is a lower-case review. Thumbs up. > > I like how the test lucidly documents the access rules, and would applaud an > extended test that additionally covers module boundaries. > > Just as a suggestion, how about using

Re: RFR 8152645 VarHandle lookup access control tests

Hi Paul, note this is a lower-case review. Thumbs up. I like how the test lucidly documents the access rules, and would applaud an extended test that additionally covers module boundaries. Just as a suggestion, how about using the fact that enum values are technically instances of subclasses o

RFR 8152645 VarHandle lookup access control tests

Hi, Please review a test to verify access control of looking up fields using a VarHandle: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8152645-VH-access-control/webrev/ For completeness i also added tests for M