On 04/07/2016 04:33 PM, Brent Christian wrote:
I will send:
http://cr.openjdk.java.net/~bchristi/8153123/webrev.02/
to hs-rt shortly.
...after adding the following :)
diff -r f628b87a6067 makefiles/symbols/symbols-unix
--- a/makefiles/symbols/symbols-unixFri Apr 08 13:14:23 2016 +0200
+
Hi, Daniel
On 04/07/2016 04:24 AM, Daniel Fuchs wrote:
In
http://cr.openjdk.java.net/~bchristi/8153123/webrev.00/hotspot/src/share/vm/prims/jvm.cpp.frames.html
548 objArrayOop fa = objArrayOop(JNIHandles::resolve_non_null(frames));
549 objArrayHandle frames_array_h(THREAD, fa);
550
Hi Brent,
This looks good! Thanks for taking care of this one.
In
http://cr.openjdk.java.net/~bchristi/8153123/webrev.00/hotspot/src/share/vm/prims/jvm.cpp.frames.html
548 objArrayOop fa = objArrayOop(JNIHandles::resolve_non_null(frames));
549 objArrayHandle frames_array_h(THREAD, fa);
On 04/05/2016 10:36 PM, Mandy Chung wrote:
Looks good. Nit: can you add a space after “synchronized” in
StackFrameInfo.java line 109:
109 synchronized(this) {
Yep - changed locally.
Thanks,
-Brent
On 4/5/16 7:48 PM, Brent Christian wrote:
Thanks, Coleen. Coordinating method/function names on "to stack trace
element" is a fine thing. I've done so in the updated webrev, and
also implemented Claes's suggestion.
http://cr.openjdk.java.net/~bchristi/8153123/webrev.01/index.html
Thank y
> On Apr 5, 2016, at 4:48 PM, Brent Christian
> wrote:
>
> Thanks, Coleen. Coordinating method/function names on "to stack trace
> element" is a fine thing. I've done so in the updated webrev, and also
> implemented Claes's suggestion.
>
> http://cr.openjdk.java.net/~bchristi/8153123/webre
Thanks, Coleen. Coordinating method/function names on "to stack trace
element" is a fine thing. I've done so in the updated webrev, and also
implemented Claes's suggestion.
http://cr.openjdk.java.net/~bchristi/8153123/webrev.01/index.html
-Brent
On 04/05/2016 11:25 AM, Coleen Phillimore wrot
A correction below.
On 4/5/16 1:29 PM, Coleen Phillimore wrote:
Also meant to include core-libs-dev in the email.
Thanks,
Coleen
On 4/5/16 1:27 PM, Coleen Phillimore wrote:
Hi, I've reviewed the hotspot changes and some of the jdk changes.
This looks really good.
One comment about the jv
Hi,
On 04/05/2016 01:45 AM, Brent Christian wrote:
Hi,
I'd like to check in some footprint and code reduction changes to the
java.lang.StackWalker implementation.
Webrev:
http://cr.openjdk.java.net/~bchristi/8153123/webrev.00/
this looks really good to me.
It seems the new implementation
Also meant to include core-libs-dev in the email.
Thanks,
Coleen
On 4/5/16 1:27 PM, Coleen Phillimore wrote:
Hi, I've reviewed the hotspot changes and some of the jdk changes.
This looks really good.
One comment about the jvm function names:
I think FillInStackTraceElement is too close of
> On Apr 4, 2016, at 4:45 PM, Brent Christian
> wrote:
>
> Hi,
>
> I'd like to check in some footprint and code reduction changes to the
> java.lang.StackWalker implementation.
>
> Webrev:
> http://cr.openjdk.java.net/~bchristi/8153123/webrev.00/
> Bug:
> https://bugs.openjdk.java.net/browse
Hi,
I'd like to check in some footprint and code reduction changes to the
java.lang.StackWalker implementation.
Webrev:
http://cr.openjdk.java.net/~bchristi/8153123/webrev.00/
Bug:
https://bugs.openjdk.java.net/browse/JDK-8153123
A summary of the changes:
* remove the "stackwalk.newThrowable
12 matches
Mail list logo
