On 4/27/16 1:00 AM, Alan Bateman wrote:
On 26/04/2016 13:50, Felix Yang wrote:
Hi Amy,
thanks for pointing this out. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/
This looks okay to me.
-Alan
Thank you Alan!
Felix, I'll sponsor this change for you.
Thanks,
On 26/04/2016 13:50, Felix Yang wrote:
Hi Amy,
thanks for pointing this out. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/
This looks okay to me.
-Alan
On 4/26/16 8:50 PM, Felix Yang wrote:
Hi Amy,
thanks for pointing this out. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/
Thank you Felix for the updated webrev. This looks clear and good :-)
Just one question, does this fix for all tests for jdk_rmi test group?
Hi Amy,
thanks for pointing this out. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/
Felix
On 2016/4/26 17:21, Amy Lu wrote:
Hi, Felix
With modules declares in TEST.propertiesshould avoid have to modify
test file one by one... Maybe I missed things please correct
On 26/04/2016 10:21, Amy Lu wrote:
Hi, Felix
With modules declares in TEST.propertiesshould avoid have to modify
test file one by one... Maybe I missed things please correct me.
Example:
$ cat jdk/test/java/rmi/TEST.properties
modules = java.rmi
Yes, this avoid needing to add @modules to e
Hi, Felix
With modules declares in TEST.propertiesshould avoid have to modify test
file one by one... Maybe I missed things please correct me.
Example:
$ cat jdk/test/java/rmi/TEST.properties
modules = java.rmi
Thanks,
Amy
On 4/26/16 4:53 PM, Felix Yang wrote:
Hi all,
please review the
Hi all,
please review the fix to explicitly declare module dependencies for
rmi tests.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154733
Webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.00/
Thanks,
Felix
