Thanks Brent, looks good!
Coleen
On 1/31/17 1:19 PM, Brent Christian wrote:
On 1/30/17 5:52 PM, Coleen Phillimore wrote:
in
http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/hotspot/src/share/vm/prims/stackwalk.cpp.html
287 int mode = 0;
288 if (_jvf->is_interpreted_frame())
> On Jan 27, 2017, at 8:26 AM, Mandy Chung wrote:
>
>
>> On Jan 26, 2017, at 5:07 PM, Brent Christian
>> wrote:
>>
>> Hi,
>>
>> Please review my updated approach for fixing 8156073 ("2-slot
>> LiveStackFrame locals (long and double) are incorrect") in the experimental
>> portion of the Sta
On 1/30/17 5:52 PM, Coleen Phillimore wrote:
in
http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/hotspot/src/share/vm/prims/stackwalk.cpp.html
287 int mode = 0;
288 if (_jvf->is_interpreted_frame()) { mode |= MODE_INTERPRETED; }
289 if (_jvf->is_compiled_frame()){ mode
Added core-libs-dev.
Coleen
On 1/30/17 5:52 PM, Coleen Phillimore wrote:
Hi Brent,
I think this looks more conservative and better.
in
http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/hotspot/src/share/vm/prims/stackwalk.cpp.html
287 int mode = 0;
288 if (_jvf->is_interpre
On 01/26/2017 05:07 PM, Brent Christian wrote:
I also removed the more simplistic CountLocalSlots.java test, given that
the updated LocalsAndOperands.java will now better cover testing -Xcomp.
I also noticed that we no longer need the LocalsCrash.java test. Removed.
-Brent
On 01/27/2017 08:26 AM, Mandy Chung wrote:
On Jan 26, 2017, at 5:07 PM, Brent Christian wrote:
Webrev: http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/
I agree with Remi to make the MODE_* constants in LiveStackFrameInfo final and
PrimitiveSlot::size() public.
Thank you for the comm
> On Jan 26, 2017, at 5:07 PM, Brent Christian
> wrote:
>
> Hi,
>
> Please review my updated approach for fixing 8156073 ("2-slot
> LiveStackFrame locals (long and double) are incorrect") in the experimental
> portion of the StackWalker API, added in JDK 9.
>
> Bug: https://bugs.openjdk.java
o Tudone (fa...@paralleluniverse.co)"
> Envoyé: Vendredi 27 Janvier 2017 02:07:09
> Objet: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are
> incorrect (updated)
> Hi,
>
> Please review my updated approach for fixing 8156073 ("2-slot
> LiveStackFrame
Hi,
Please review my updated approach for fixing 8156073 ("2-slot
LiveStackFrame locals (long and double) are incorrect") in the
experimental portion of the StackWalker API, added in JDK 9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8156073
Webrev: http://cr.openjdk.java.net/~bchristi/81560
