Re: RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread joe darcy
Note that the two existing catch blocks 243 } catch (Exception t) { 244 t.printStackTrace(System.err); 245 failed.add(s); 246 } catch (NoClassDefFoundError e) { 247 e.printStackTrace(System.err); 248 failed.add(s); 249

Re: RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread Aleksey Shipilev
On 05/17/2016 04:26 PM, Sundararajan Athijegannathan wrote: > Please review the updated webrev: > http://cr.openjdk.java.net/~sundar/8157146/webrev.01/ Yes, reviewed. Thanks, -Aleksey

Re: RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread Alan Bateman
On 17/05/2016 14:26, Sundararajan Athijegannathan wrote: Please review the updated webrev: http://cr.openjdk.java.net/~sundar/8157146/webrev.01/ This version looks okay to me. Now let's see if I find out where the bad class is coming from. -Alan

Re: RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread Sundararajan Athijegannathan
Please review the updated webrev: http://cr.openjdk.java.net/~sundar/8157146/webrev.01/ Thanks, -Sundar On 5/17/2016 6:42 PM, Alan Bateman wrote: > On 17/05/2016 14:08, Aleksey Shipilev wrote: >> On 05/17/2016 03:54 PM, Sundararajan Athijegannathan wrote: >>> Please review http://cr.openjdk.jav

Re: RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread Alan Bateman
On 17/05/2016 14:08, Aleksey Shipilev wrote: On 05/17/2016 03:54 PM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8157146/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8157146 Shouldn't it follow the same pattern other catch blocks? Surely you w

Re: RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread Aleksey Shipilev
On 05/17/2016 03:54 PM, Sundararajan Athijegannathan wrote: > Please review http://cr.openjdk.java.net/~sundar/8157146/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8157146 Shouldn't it follow the same pattern other catch blocks? Surely you want to run all test cases, and not abort on

RFR 8157146: Add debug printlns to tests FieldSetAccessibleTest and VerifyJimage.java

2016-05-17 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8157146/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8157146 This is test only change to debug printlns. Thanks, -Sundar