Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-12-01 Thread Xueming Shen
On 12/01/2016 12:05 PM, Paul Sandoz wrote: On 1 Dec 2016, at 11:17, Xueming Shen wrote: On 11/28/2016 11:27 AM, Paul Sandoz wrote: On 25 Nov 2016, at 02:47, Tobias Hartmann wrote: I'm not sure if it is still desired to do the same

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-12-01 Thread Paul Sandoz
> On 1 Dec 2016, at 11:17, Xueming Shen wrote: > > On 11/28/2016 11:27 AM, Paul Sandoz wrote: >>> On 25 Nov 2016, at 02:47, Tobias Hartmann >>> wrote: >>> I'm not sure if it is still desired to do the same boundary check in case

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-12-01 Thread Xueming Shen
On 11/28/2016 11:27 AM, Paul Sandoz wrote: On 25 Nov 2016, at 02:47, Tobias Hartmann wrote: I'm not sure if it is still desired to do the same boundary check in case of LATIN1 for the benefit of consistency. Assume there might be concurrent access/operation

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-11-28 Thread Paul Sandoz
> On 25 Nov 2016, at 02:47, Tobias Hartmann wrote: > >> I'm not sure if it is still desired to do the same boundary check in case of >> LATIN1 >> for the benefit of consistency. Assume there might be concurrent >> access/operation >> between val = this.value and

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-11-25 Thread Tobias Hartmann
Hi, On 24.11.2016 00:56, Xueming Shen wrote: > On 11/23/2016 02:39 PM, Paul Sandoz wrote: >> Hi, >> >> Please review: >> >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8170155-string-buffer-builder-late-binding/webrev/ >> >> This patch: >> >> 1) updates the

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-11-23 Thread Xueming Shen
On 11/23/2016 02:39 PM, Paul Sandoz wrote: Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8170155-string-buffer-builder-late-binding/webrev/ This patch: 1) updates the StringBuilder/StringBuffer.chars()/codePoints() so they are late binding. 2) refactors the

RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

2016-11-23 Thread Paul Sandoz
Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8170155-string-buffer-builder-late-binding/webrev/ This patch: 1) updates the StringBuilder/StringBuffer.chars()/codePoints() so they are late binding. 2) refactors the spliterator late binding and fail fast tests, separating