Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-05 Thread Alan Bateman
On 04/12/2017 20:18, mandy chung wrote: On 12/4/17 12:11 PM, Brent Christian wrote: So rethrow RuntimeExceptions directly, whether they're the cause of an InvocationTargetException or not. Updated webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.02/ Looks good. Yes, I think t

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-04 Thread mandy chung
On 12/4/17 12:11 PM, Brent Christian wrote: So rethrow RuntimeExceptions directly, whether they're the cause of an InvocationTargetException or not. Updated webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.02/ Looks good. Thanks Mandy

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-04 Thread Brent Christian
On 12/1/17 5:22 PM, Mandy Chung wrote: > > I think should also rethrow the cause if the cause is an Error > (why not) Alright. The instanceof RuntimeException check should be moved outside to the if-statement when it’s an instance of InvocationTargetException. So rethrow RuntimeExceptions dir

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-01 Thread Mandy Chung
> On Dec 1, 2017, at 5:17 PM, Mandy Chung wrote: > > >>> On Dec 1, 2017, at 4:46 PM, Brent Christian >>> wrote: >>> >>> On 12/1/17 11:40 AM, Brent Christian wrote: >>> On 12/1/17 8:33 AM, mandy chung wrote: > Better still might be for initSystemClassLoader to re-throw the cause so

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-01 Thread Mandy Chung
> On Dec 1, 2017, at 4:46 PM, Brent Christian > wrote: > >> On 12/1/17 11:40 AM, Brent Christian wrote: >> On 12/1/17 8:33 AM, mandy chung wrote: Better still might be for initSystemClassLoader to re-throw the cause so that it appears immediately after the "Error occurred during >>>

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-01 Thread Brent Christian
On 12/1/17 11:40 AM, Brent Christian wrote: On 12/1/17 8:33 AM, mandy chung wrote: Better still might be for initSystemClassLoader to re-throw the cause so that it appears immediately after the "Error occurred during initialization of VM" message that the VM will fail with. Yes that would be

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-01 Thread Brent Christian
On 12/1/17 8:33 AM, mandy chung wrote: Better still might be for initSystemClassLoader to re-throw the cause so that it appears immediately after the "Error occurred during initialization of VM" message that the VM will fail with. Yes that would be better. So would I do this for RuntimeExcep

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-01 Thread mandy chung
On 12/1/17 2:32 AM, Alan Bateman wrote: On 30/11/2017 22:57, mandy chung wrote: : This is indeed a bug that should throw ISE when ClassLoader.getSystemClassLoader is called during the initialization of the system class loader, as the spec states. line 1921: I suggest to revise the message

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-12-01 Thread Alan Bateman
On 30/11/2017 22:57, mandy chung wrote: : This is indeed a bug that should throw ISE when ClassLoader.getSystemClassLoader is called during the initialization of the system class loader, as the spec states. line 1921: I suggest to revise the message to make it clearer:      "getSystemClassLo

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-11-30 Thread mandy chung
On 11/30/17 1:35 PM, Brent Christian wrote: Hi, Please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8187222 Webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.00/ Thanks for fixing it. This is indeed a bug that should throw ISE when ClassLoader.getS

RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

2017-11-30 Thread Brent Christian
Hi, Please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8187222 Webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.00/ The method description of ClassLoader.getSystemClassLoader() states (in regards to setting a custom system classloader): "If circular