Re: RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-30 Thread Brent Christian
Thank you for the reviews! -Brent

Re: RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-27 Thread Roger Riggs
+1 On 10/27/17 5:39 PM, mandy chung wrote: On 10/27/17 2:37 PM, Brent Christian wrote: On 10/27/2017 11:19 AM, mandy chung wrote: It may be cleaner to initialize the map in a single place e.g. a private constructor taking Properties and initialCapacity. Yeah, that's a good idea.  See new

Re: RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-27 Thread mandy chung
On 10/27/17 2:37 PM, Brent Christian wrote: On 10/27/2017 11:19 AM, mandy chung wrote: It may be cleaner to initialize the map in a single place e.g. a private constructor taking Properties and initialCapacity. Yeah, that's a good idea.  See new webrev:

Re: RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-27 Thread Brent Christian
On 10/27/2017 11:19 AM, mandy chung wrote: It may be cleaner to initialize the map in a single place e.g. a private constructor taking Properties and initialCapacity. Yeah, that's a good idea. See new webrev: http://cr.openjdk.java.net/~bchristi/8189319/webrev.02/index.html Thanks, -Brent

Re: RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-27 Thread Martin Buchholz
I completely missed the fact that Properties continues to inherit from Hashtable but the data is actually stored in a CHM. I would have been afraid to make that change ... Looks good! On Thu, Oct 26, 2017 at 6:43 PM, Brent Christian wrote: > Hi, > > It would be

Re: RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-27 Thread mandy chung
On 10/26/17 6:43 PM, Brent Christian wrote: Hi, It would be useful to have a Properties constructor that takes an argument to set the initial capacity. Such a constructor is present on many of the other Map implementations in the JDK, including Hashtable, the superclass of Properties. In

RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity

2017-10-26 Thread Brent Christian
Hi, It would be useful to have a Properties constructor that takes an argument to set the initial capacity. Such a constructor is present on many of the other Map implementations in the JDK, including Hashtable, the superclass of Properties. In particular, being able to specify the initial