Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-05 Thread Brian Burkhalter
Indeed it looks like NetworkServer could be removed. Question is what else in that package could be removed? Could be a separate issue. On Jan 5, 2018, at 3:27 AM, Alan Bateman wrote: > Sorry for prolonging this one but is sun.net.NetworkServer used by anything? > I suspect it's a left over fr

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-05 Thread Alan Bateman
On 04/01/2018 17:18, Brian Burkhalter wrote: Patch updated per this e-mail thread: http://cr.openjdk.java.net/~bpb/8194133/webrev.01/ Sorry for prolonging this one but is sun.net.NetworkServer used by anything? I suspect it's a left ove

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-04 Thread Brian Burkhalter
On Jan 4, 2018, at 12:06 AM, Alan Bateman wrote: > So not clear to me that Files.copy methods needs to use this. So you are suggesting leaving the call to InputStream.transferTo() in preference to IOSupport.copy()? >>> Yes, I think these two should use transferTo. >> >> I do

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-04 Thread Alan Bateman
On 04/01/2018 01:48, Brian Burkhalter wrote: On Jan 3, 2018, at 3:23 AM, Alan Bateman > wrote: On 02/01/2018 23:43, Brian Burkhalter wrote: : So not clear to me that Files.copy methods needs to use this. So you are suggesting leaving the call to InputStrea

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-03 Thread Brian Burkhalter
On Jan 3, 2018, at 3:23 AM, Alan Bateman wrote: > On 02/01/2018 23:43, Brian Burkhalter wrote: >> : >> >>> So not clear to me that Files.copy methods needs to use this. >> >> So you are suggesting leaving the call to InputStream.transferTo() in >> preference to IOSupport.copy()? > Yes, I think

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-03 Thread Alan Bateman
On 02/01/2018 23:43, Brian Burkhalter wrote: : So not clear to me that Files.copy methods needs to use this. So you are suggesting leaving the call to InputStream.transferTo() in preference to IOSupport.copy()? Yes, I think these two should use transferTo. -Alan

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-02 Thread Brian Burkhalter
On Jan 2, 2018, at 9:01 AM, Alan Bateman wrote: >> One thing that I noticed when looking at this is that in the fix for >> https://bugs.openjdk.java.net/browse/JDK-8193842, the Files.copy() method >> had a loop like >> >> while ((n = read(…)) > 0) >> >> whereas InputStream.transferTo() had >

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-02 Thread Alan Bateman
On 22/12/2017 21:51, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8194133 http://cr.openjdk.java.net/~bpb/8194133/webrev.00/ Add jdk.internal.io.IOSupport with copy() methods for InputStream-to-OutputStream copying and modify some classes to use these new methods. One thin

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2017-12-23 Thread Remi Forax
gt; À: "core-libs-dev" > Envoyé: Vendredi 22 Décembre 2017 22:51:17 > Objet: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility > method > https://bugs.openjdk.java.net/browse/JDK-8194133 > http://cr.openjdk.java.net/~bpb/8194133/webrev.00/ > > A

RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2017-12-22 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8194133 http://cr.openjdk.java.net/~bpb/8194133/webrev.00/ Add jdk.internal.io.IOSupport with copy() methods for InputStream-to-OutputStream copying and modify some classes to use these new methods. One thing that I noticed when looking at this is that i