Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread forax
- Mail original - > De: "John Rose" > À: "Peter Levart" > Cc: "Remi Forax" , "core-libs-dev" > > Envoyé: Mercredi 11 Juillet 2018 21:07:37 > Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not >

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread forax
- Mail original - > De: "Peter Levart" > À: "Remi Forax" > Cc: "Paul Sandoz" , "core-libs-dev" > > Envoyé: Mercredi 11 Juillet 2018 18:32:13 > Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not > s

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread John Rose
, "core-libs-dev" >>> >>> Envoyé: Mercredi 11 Juillet 2018 17:15:09 >>> Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not >>> support default methods >>> Hi Paul, >>> >>> The patch looks ok. I hope IMP

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread Paul Sandoz
Hi Peter, > On Jul 11, 2018, at 8:15 AM, Peter Levart wrote: > > Hi Paul, > > The patch looks ok. Thanks. > I hope IMPL_LOOKUP has access to all methods (even if located in > package-private interfaces and/or in concealed packages of modules)? > I think it should be ok, because IMPL_LOOKU

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread Peter Levart
dleProxies.asInterfaceInstance does not support default methods Hi Paul, The patch looks ok. I hope IMPL_LOOKUP has access to all methods (even if located in package-private interfaces and/or in concealed packages of modules)? Just a thought... Would it be possible to implement this API in terms o

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread Remi Forax
- Mail original - > De: "Peter Levart" > À: "Paul Sandoz" , "core-libs-dev" > > Envoyé: Mercredi 11 Juillet 2018 17:15:09 > Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not > support default methods > Hi Pa

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-11 Thread Peter Levart
Hi Paul, The patch looks ok. I hope IMPL_LOOKUP has access to all methods (even if located in package-private interfaces and/or in concealed packages of modules)? Just a thought... Would it be possible to implement this API in terms of LambdaMetafactory ? Regards, Peter On 07/11/2018 12:

Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-10 Thread mandy chung
This patch looks good to me. Mandy On 7/10/18 3:43 PM, Paul Sandoz wrote: Hi, Please review this fix to MethodHandleProxies.asInterfaceInstance to support default methods: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8206955-mh-func-iface-proxy-default-methods/webrev/ It probably requires a

RFR 8206955 MethodHandleProxies.asInterfaceInstance does not support default methods

2018-07-10 Thread Paul Sandoz
Hi, Please review this fix to MethodHandleProxies.asInterfaceInstance to support default methods: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8206955-mh-func-iface-proxy-default-methods/webrev/