RE: RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

2020-02-21 Thread Langer, Christoph
; core-libs-dev@openjdk.java.net Subject: Re: RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation Morning Christoph, On Feb 21, 2020, at 3:11 AM, Langer, Christoph mailto:christoph.lan...@sap.com>> wrote: Hi Lance, thanks for reviewing. Any results from

Re: RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

2020-02-21 Thread Lance Andersen
20:00 > To: Langer, Christoph <mailto:christoph.lan...@sap.com>> > Cc: nio-...@openjdk.java.net <mailto:nio-...@openjdk.java.net>; > core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> > Subject: Re: RFR 8239556: (zipfs) remove ExistingChannelCloser faci

RE: RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

2020-02-21 Thread Langer, Christoph
urrent proposal for JDK-8225507 to overhaul exception handling in close()&sync(). Cheers Christoph From: Lance Andersen Sent: Donnerstag, 20. Februar 2020 20:00 To: Langer, Christoph Cc: nio-...@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: Re: RFR 8239556: (zipfs) remove Ex

Re: RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

2020-02-20 Thread Lance Andersen
Hi Christoph, This looks good and thank you for tackling. We will need to regenerate the web-rev for the Manifest fix after this gets pushed I am running Mach5 tiers 1-3 now and will let you know when it completes > On Feb 20, 2020, at 8:33 AM, Langer, Christoph > wrote: > > Hi, > > pleas

RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

2020-02-20 Thread Langer, Christoph
Hi, please review this cleanup change to remove the ExistingChannelCloser facility in zipfs. Some technical details about why this existed can be found in this mailing list thread, where Sherman explained its original purpose: https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-April/05