Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

2015-06-23 Thread Volker Simonis
Hi Roger, thanks for doing this change! I already had this on my list as well as we at SAP are also still using VS2010 - and probably will use it for quite some time :( The bug was actually a C99 feature which isn't supported by the C-compiler of VS2010 (see http://herbsutter.com/2012/05/03/reade

Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

2015-06-23 Thread Alan Bateman
On 23/06/2015 14:20, Roger Riggs wrote: Hi Alan, Dropping VS2010 should probably a deliberate choice/state, not just an oversight in coding. Its also a style question, if this were shared code I think Solaris also complains about inline declarations; but that too may be due to an older tool

Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

2015-06-23 Thread Roger Riggs
Hi Alan, Dropping VS2010 should probably a deliberate choice/state, not just an oversight in coding. Its also a style question, if this were shared code I think Solaris also complains about inline declarations; but that too may be due to an older tool chain. Thanks, Roger On 6/23/2015 2:42

Re: RFR 9: 8129535: java_props_md.c should compile on VS 2010

2015-06-22 Thread Alan Bateman
On 23/06/2015 04:50, Roger Riggs wrote: Please review a minor correction so java_props_md.c will compile with Visual Studio 2010. (Declarations are allowed in the middle of blocks only in later versions). Webrev: http://cr.openjdk.java.net/~rriggs/webrev-props-vs1010-8129535/ Issue: https:/

RFR 9: 8129535: java_props_md.c should compile on VS 2010

2015-06-22 Thread Roger Riggs
Please review a minor correction so java_props_md.c will compile with Visual Studio 2010. (Declarations are allowed in the middle of blocks only in later versions). Webrev: http://cr.openjdk.java.net/~rriggs/webrev-props-vs1010-8129535/ Issue: https://bugs.openjdk.java.net/browse/JDK-8129