Re: RFR JDK-8011426: java.util collection Spliterator implementations

2013-04-19 Thread Paul Sandoz
On Apr 19, 2013, at 6:52 AM, Mike Duigou wrote: > I reversed this change : > > -final Collection c; > - > +final Collection c; > > > in Collections.UnmodifiableCollection instead opting or casts in the forEach > and spliterator Methods. > OK, i prefer the former but i ain't gonna a

Re: RFR JDK-8011426: java.util collection Spliterator implementations

2013-04-18 Thread Mike Duigou
I reversed this change : -final Collection c; - +final Collection c; in Collections.UnmodifiableCollection instead opting or casts in the forEach and spliterator Methods. - I wonder if it's worth it to have the NONNULL characteristic change in Collections::singletonSpliterator depend

Re: RFR JDK-8011426: java.util collection Spliterator implementations

2013-04-16 Thread Paul Sandoz
Hi Mike, Thanks for looking at this. On Apr 16, 2013, at 5:39 AM, Mike Duigou wrote: > I went back and started again with the 8010096 webrev. > > Spliterators:: > > - some implementations are private and some are package private. All package > private? > I don't think there is any need to

Re: RFR JDK-8011426: java.util collection Spliterator implementations

2013-04-15 Thread Mike Duigou
I went back and started again with the 8010096 webrev. Spliterators:: - some implementations are private and some are package private. All package private? List/Set/Iterator/SortedSet:: - Include the same interface level @implSpec warning as Collection? Spliterator:: - "Spliterators also rep

RFR JDK-8011426: java.util collection Spliterator implementations

2013-04-10 Thread Paul Sandoz
Hi, Following up from JDK-8010096 [1] here is a webrev for spliterator implementations of collection classes in java.util: http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8011426/webrev/ This is dependent on [1]. -- Note that for some reason the webrev script creates the jdk chan