Hi Sherman,
I found updates in http://cr.openjdk.java.net/~sherman/8164278/webrev.04
That looks fine.
Typo: line 1008: "neve"
Roger
On 2/7/2018 10:32 PM, Xueming Shen wrote:
Hi Roger,
Given the concern of the possible incompatible behavior change of over
reading bytes
from the underlyin
Hi Roger,
Given the concern of the possible incompatible behavior change of over
reading bytes
from the underlying stream. I decided to give up last proposed changes
for DecInputStream
for now. With some "minor" cleanup and tuning I still have about 10%+
improvement with
various input size sam
On 2/6/18, 8:56 AM, Xueming Shen wrote:
848: checkNewline compares == with linemax; that works when each byte
is counted separately
It seems like it would safer if it was ">=".
updated.
I took it back. >= does not work here.
-sherman
On 2/6/18, 8:28 AM, Roger Riggs wrote:
Hi Sherman,
On 2/5/2018 9:00 PM, Xueming Shen wrote:
Hi,
Please help review the change for JDK-8164278.
issue: https://bugs.openjdk.java.net/browse/JDK-8164278
webrev: http://cr.openjdk.java.net/~sherman/8164278/webrev
Are the reentrant locks necessary?
Hi Sherman,
On 2/5/2018 9:00 PM, Xueming Shen wrote:
Hi,
Please help review the change for JDK-8164278.
issue: https://bugs.openjdk.java.net/browse/JDK-8164278
webrev: http://cr.openjdk.java.net/~sherman/8164278/webrev
Are the reentrant locks necessary? concurrent reads from streams are
not
Hi,
Please help review the change for JDK-8164278.
issue: https://bugs.openjdk.java.net/browse/JDK-8164278
webrev: http://cr.openjdk.java.net/~sherman/8164278/webrev
jmh.src: http://cr.openjdk.java.net/~sherman/8164278/Base64BM.java
jmh.result: http://cr.openjdk.java.net/~sherman/8164278/base6
