Re: RFR JDK-8170952: jar's usage message output need some cleanup

2016-12-09 Thread Xueming Shen
thanks! webrev has been updated accordingly. http://cr.openjdk.java.net/~sherman/8170952/ On 12/9/16 3:49 AM, Andrej Golovnin wrote: Hi, src/jdk.jartool/share/classes/sun/tools/jar/Main.java 682 if (info != null) { 683 info.print(out); 684

Re: RFR JDK-8170952: jar's usage message output need some cleanup

2016-12-09 Thread Andrej Golovnin
Hi, src/jdk.jartool/share/classes/sun/tools/jar/Main.java 682 if (info != null) { 683 info.print(out); 684return true; 685 } The indentation in the line 684 is wrong: it uses 3 spaces instead of 4. Best regards, Andrej

Re: RFR JDK-8170952: jar's usage message output need some cleanup

2016-12-09 Thread Chris Hegarty
On 09/12/16 00:13, Xueming Shen wrote: Hi, Please help some trival usage msg clean of the jar command issue: https://bugs.openjdk.java.net/browse/JDK-8170952 webrev: http://cr.openjdk.java.net/~sherman/8170952/ Thank you Sherman, the code changes look good to me. -Chris.

RFR JDK-8170952: jar's usage message output need some cleanup

2016-12-08 Thread Xueming Shen
Hi, Please help some trival usage msg clean of the jar command issue: https://bugs.openjdk.java.net/browse/JDK-8170952 webrev: http://cr.openjdk.java.net/~sherman/8170952/ 321 static void printUsageSummary(PrintWriter out) { 322 out.format("%s%n", Main.getMsg("main.usage.summary