On 12/7/17, 8:31 AM, mandy chung wrote:
On 12/4/17 3:14 PM, Xueming Shen wrote:
issue: https://bugs.openjdk.java.net/browse/JDK-8185582
webrev: http://cr.openjdk.java.net/~sherman/8185582/webrev
ZStreamRef.java
79 static ZStreamRef get(Object owner, LongSupplier addr, LongConsumer
On 12/4/17 3:14 PM, Xueming Shen wrote:
issue: https://bugs.openjdk.java.net/browse/JDK-8185582
webrev: http://cr.openjdk.java.net/~sherman/8185582/webrev
ZStreamRef.java 79 static ZStreamRef get(Object owner, LongSupplier
addr, LongConsumer end) {
It may be better to have two factory meth
Hi Sherman,
Looking good.
Deflater(573) and Inflater(398), and ZipFile(890):
For consistency, where is says "phantom-reachable" in the finalize
methods it can say "unreachable".
ZStreamRef:
- line 92: FinalizableZStreamRef - owner should be final
Regards, Roger
On 12/4/2017 6:14 PM, X
Hi
Please review the revision to the change for
JDK-8187485: Update Zip implementation to use Cleaner, not finalizers
For compatibility with previous jdk releases, in this proposed revision
the corresponding
close()/end() methods will be called when the ZipFile/Inflater/Deflater
object has be