Hi,
Please help review the changeset for JDK-8200530.
"newline" is specified as |CR LF | LF | CR|(/not followed by/|LF|) in
Jar spec [1] from
the very beginning but our implementation actually never supports
"\r"/CR (not
followed by LF) case. The proposed change here is to add CR as an indivi
Attributes.java:380 nit
- assign c at decl
- only test len if decremented
>>
byte c;
if ((c = lbuf[--len]) != '\n' && c != '\r') {
throw new IOException("line too long");
}
if (len > 0 && lbuf[len-1] == '\r') {
-
Thanks Jim! webrev has been updated as suggested.
http://cr.openjdk.java.net/~sherman/8200530/webrev
-sherman
On 06/05/2018 05:17 AM, Jim Laskey wrote:
Attributes.java:380 nit
- assign c at decl
- only test len if decremented
byte c;
if ((c = lbuf[--len]) != '\n'&&
