Re: RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

2018-09-19 Thread Brian Burkhalter
Hi Sherman On Sep 18, 2018, at 6:45 PM, Xueming Shen wrote: > Thanks looking into it. You’re welcome. > Yes, the current code (with the change for JDK-8034802) fails both of the > added > checks. Thanks for the update. Brian

Re: RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

2018-09-18 Thread Xueming Shen
On 9/18/18, 5:50 PM, Brian Burkhalter wrote: Hi Sherman, This looks fine to me. Does the current code fail both of the added checks in the test? Hi Brian, Thanks looking into it. Yes, the current code (with the change for JDK-8034802) fails both of the added checks. Thanks, Shermzn

Re: RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

2018-09-18 Thread Brian Burkhalter
Hi Sherman, This looks fine to me. Does the current code fail both of the added checks in the test? Thanks, Brian On Sep 18, 2018, at 5:14 PM, Xueming Shen wrote: > Please help codereview the change for JDK-8210899. > > issue: https://bugs.openjdk.java.net/browse/JDK-8210899 > webrev: http:

RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

2018-09-18 Thread Xueming Shen
Hi, Please help codereview the change for JDK-8210899. issue: https://bugs.openjdk.java.net/browse/JDK-8210899 webrev: http://cr.openjdk.java.net/~sherman/8210899/webrev Thanks, Sherman