Hi Eric, Martin,
I'm fine with the re-write. I'm not sure why the re-ordering of y3 will
change the
behavior of the test but it will provide more debugging info.
Roger
On 6/6/2014 9:32 PM, Martin Buchholz wrote:
If you don't want to go with my rewrite, you can conservatively just
check in a
On 5/06/2014 5:25 AM, Martin Buchholz wrote:
Tests for Timer are inherently timing (!) dependent.
It's reasonable for tests to assume that:
- reasonable events like creating a thread and executing a simple task
should complete in less than, say 2500ms.
Not necessarily with the wrong combination
Hi Martin, Eric,
Of several hundred failures of this test, most were done in a JRE run with
-Xcomp set. A few failures occurred with -Xmixed, none with -Xint.
The printed "elapsed" times (not normalized to hardware or OS) range from
24 to 132 (ms) with most falling into several buckets in the 3
Hi Martin,
Thanks for explanation, now I can understand why you set the DELAY_MS to
100 seconds, it is true that it prevents failure on a slow host,
however, i still have some concerns.
Because the test tests to schedule tasks at the time in the past, so all
13 tasks should be executed immedia
Hi Martin,
To sleep(1000) is not enough to reproduce the failure, because it is
much lower than the period DELAY_MS (10*1000) of the repeated task
created by "scheduleAtFixedRate(t, counter(y3), past, DELAY_MS)".
Try sleep(DELAY_MS), the failure can be reproduced.
Thanks,
Eric
On 2014/6/4 8:
Hi Martin,
Is it possible that the main thread takes too long to go from y3.await()
to the t.cancel() that the fixed rate timer (y3) gets called again?
It seems unlikely, but with the printf, its not just compute time.
Canceling the timer before the printf would likely reduce the failures.
Anot
Hi Martin,
Glad to know you are the original author and thank you to rewrite the
test using modern way.
I have some concerns about the limit of elapsed time (DELAY_MS / 2 =
5ms) which is much higher than the old value (500ms).
The reason is that i checked the nightly failure histories, th
Hi,
Please help to review the fix for bug
https://bugs.openjdk.java.net/browse/JDK-8004807 as below:
http://cr.openjdk.java.net/~ewang/JDK-8004807/webrev.00/
The root cause of the failure is if Timer.cancel() is not called in
time, the recurring timer task keeps running which cause the the
a
