Re: RFR of JDK-8049316: TEST_BUG: java/nio/channels/Selector/Wakeup.java fails in same binary run b19

2016-11-30 Thread Hamlin Li
Hi Roger, Thank you for reviewing, fixed timeout scale and pushed. Thank you -Hamlin On 2016/12/1 3:49, Roger Riggs wrote: Hi Hamlin, On 11/29/2016 9:09 PM, Hamlin Li wrote: Hi Roger, Thank you for reviewing, please check comments in line. webrev: http://cr.openjdk.java.net/~mli/8049316/w

Re: RFR of JDK-8049316: TEST_BUG: java/nio/channels/Selector/Wakeup.java fails in same binary run b19

2016-11-30 Thread Roger Riggs
Hi Hamlin, On 11/29/2016 9:09 PM, Hamlin Li wrote: Hi Roger, Thank you for reviewing, please check comments in line. webrev: http://cr.openjdk.java.net/~mli/8049316/webrev.01/ On 2016/11/30 0:03, Roger Riggs wrote: Hi Hamlin, Wakeup.java: - Some refactoring may make it easier to underst

Re: RFR of JDK-8049316: TEST_BUG: java/nio/channels/Selector/Wakeup.java fails in same binary run b19

2016-11-29 Thread Hamlin Li
Hi Roger, Thank you for reviewing, please check comments in line. webrev: http://cr.openjdk.java.net/~mli/8049316/webrev.01/ On 2016/11/30 0:03, Roger Riggs wrote: Hi Hamlin, Wakeup.java: - Some refactoring may make it easier to understand. Perhaps moving waitSleeper to be a method on S

Re: RFR of JDK-8049316: TEST_BUG: java/nio/channels/Selector/Wakeup.java fails in same binary run b19

2016-11-29 Thread Roger Riggs
Hi Hamlin, Wakeup.java: - Some refactoring may make it easier to understand. Perhaps moving waitSleeper to be a method on Sleeper. The use of cyclicBarrier seems fine but could use a comment somewhere saying what threads/functions are being coordinated; putting them both in Sleeper woul

RFR of JDK-8049316: TEST_BUG: java/nio/channels/Selector/Wakeup.java fails in same binary run b19

2016-11-29 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8049316 webrev: http://cr.openjdk.java.net/~mli/8049316/webrev.00/ Root cause: 1. it depends on sleeping time to check failure, which is not reliable in some extreme situation 2. it mix several tests togethe