Re: RFR of JDK-8171142: jdk_rmi registry test fail to clean up on failure

2017-01-24 Thread Hamlin Li
Hi Roger, David, Thank you for reviewing, modified as you suggested, and the code is pushed. -Hamlin On 2017/1/23 23:21, Roger Riggs wrote: Hi Hamlin, test/javax/rmi/PortableRemoteObject/ConcurrentHashMapTest.java: line 130: trivial, but please add a space in "!=null"... Note: on Windows

Re: RFR of JDK-8171142: jdk_rmi registry test fail to clean up on failure

2017-01-23 Thread David Holmes
Hi Hamlin, Thanks for tackling this one. On 23/01/2017 4:38 PM, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8171142 webrev: http://cr.openjdk.java.net/~mli/8171142/webrev.00/ As I commented in the bug report, and as Roger also ment

Re: RFR of JDK-8171142: jdk_rmi registry test fail to clean up on failure

2017-01-23 Thread Roger Riggs
Hi Hamlin, test/javax/rmi/PortableRemoteObject/ConcurrentHashMapTest.java: line 130: trivial, but please add a space in "!=null"... Note: on Windows there is no difference between Process.destroy vs Process.destroyForcibly, but on Linux it it is the difference between kill -15 and kill -9.

RFR of JDK-8171142: jdk_rmi registry test fail to clean up on failure

2017-01-22 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8171142 webrev: http://cr.openjdk.java.net/~mli/8171142/webrev.00/ Thank you -Hamlin