Hi Kumar,
I explained the formatting changein a previous email, but I see now the
formatting change I did on line 82 makes it inconsistent with similar
source on line 82, so I'll change it back.
thanks,
Chris
On 3/16/17 9:56 AM, Kumar Srinivasan wrote:
Hello,
I can't recall why String vs
Hello,
I can't recall why String vs int.
Formatting seems off,
81 tr = doExec(javaCmd, "-Xms64m", "-Xmx512m",
82 "-Xss" + stackSize + "k", "-XshowSettings", "-jar",
testJar.getAbsolutePath());
83 containsAllOptions(tr);
84 if (!tr.isOK()) {
85
Hi Chris,
changes look good, the only note, seems like formatting moved a bit
-"-Xss" + stackSize + "000", "-XshowSettings", "-jar",
testJar.getAbsolutePath());
+"-Xss" + (stackSize * 1024), "-XshowSettings", "-jar",
testJar.getAbsolutePath());
Best regards,
@openjdk.java.net
Subject: RRF(XS)(10): 8176797: [TESTBUG] tools/launcher/Settings.java -Xss size
is too small
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8176797
http://cr.openjdk.java.net/~cjplummer/8176797/webrev.00/webrev.jdk
After fixing 8175342 (see the other RFR I
Hi Chris,
Looks good to me.
Thanks,
David
On 16/03/2017 2:59 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8176797
http://cr.openjdk.java.net/~cjplummer/8176797/webrev.00/webrev.jdk
After fixing 8175342 (see the other RFR I just posted
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8176797
http://cr.openjdk.java.net/~cjplummer/8176797/webrev.00/webrev.jdk
After fixing 8175342 (see the other RFR I just posted), this test
started to fail instead of assert. The problem is 256000 is too small of
a
