Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-22 Thread serguei.spit...@oracle.com
, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent Hi Matthias, The fix looks good to me. It must be tested at least with the JTreg com/sun/jdi tests. Do you need a sponsor? Thanks, Serguei On 5/16/17 03:21, Baesken, Matthias wrote: Sure, I forward it to

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-22 Thread Baesken, Matthias
...@oracle.com] Sent: Freitag, 19. Mai 2017 02:18 To: Baesken, Matthias ; Alan Bateman ; core-libs-dev@openjdk.java.net; serviceability-...@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent Hi Matthias, The fix looks good to me. It must be

Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-18 Thread serguei.spit...@oracle.com
[mailto:alan.bate...@oracle.com] Sent: Dienstag, 16. Mai 2017 11:51 To: Baesken, Matthias ; core-libs-dev@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent On 16/05/2017 10:04, Baesken, Matthias wrote: Hello, could you please review this small change

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-18 Thread Baesken, Matthias
half Of Dmitry Samersoff > Sent: Dienstag, 16. Mai 2017 13:18 > To: Baesken, Matthias ; Alan Bateman > ; core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > Matthias, > > Looks good to me. >

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-18 Thread Langer, Christoph
t; Sent: Dienstag, 16. Mai 2017 13:18 > To: Baesken, Matthias ; Alan Bateman > ; core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > Matthias, > > Looks good to me. > > -Dmitry &g

Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-16 Thread Dmitry Samersoff
; > core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > > > On 16/05/2017 10:04, Baesken, Matthias wrote: >> Hello, could you please review this small change : >> >> http://cr.o

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-16 Thread Baesken, Matthias
Sure, I forward it to serviceability-dev . -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Dienstag, 16. Mai 2017 11:51 To: Baesken, Matthias ; core-libs-dev@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in

Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-16 Thread Alan Bateman
On 16/05/2017 10:04, Baesken, Matthias wrote: Hello, could you please review this small change : http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ it fixes a number of places in jdk.jdwp.agent where in case of an error it is attempted to write to NULL . Bug : JDK-8180413 : avoid ac

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

2017-05-16 Thread Langer, Christoph
Hi Matthias, this definitely makes sense. If 'data' is NULL, one should not access its fields, except a hard crash is desired... Reviewed. Don't forget to update the copyright year. Best regards Christoph From: Baesken, Matthias Sent: Dienstag, 16. Mai 2017 11:05 To: core-libs-dev@openjdk.java