Re: 8229022: BufferedReader performance can be improved by using StringBuilder

2019-10-02 Thread Daniel Fuchs
Hi Brian, Looks good to me. On 02/10/2019 01:13, Brian Burkhalter wrote: While the performance improvement that I measured for this proposed change [1] using JMH was only in the 2% to 8% range as opposed to the 13% claimed in the issue description, given the simplicity of the change [2] it is

Re: 8229022: BufferedReader performance can be improved by using StringBuilder

2019-10-01 Thread Vyom Tiwari
Hi Brian, Looks good to me. thanks, Vyom On Wed, Oct 2, 2019 at 5:44 AM Brian Burkhalter wrote: > While the performance improvement that I measured for this proposed change > [1] using JMH was only in the 2% to 8% range as opposed to the 13% claimed > in the issue description, given the simplici

Re: 8229022: BufferedReader performance can be improved by using StringBuilder

2019-10-01 Thread Ivan Gerasimov
Hi Brian! This looks good to me! With kind regards, Ivan On 10/1/19 5:13 PM, Brian Burkhalter wrote: While the performance improvement that I measured for this proposed change [1] using JMH was only in the 2% to 8% range as opposed to the 13% claimed in the issue description, given the sim