Re: Draft JEP: Reimplement Core Reflection on Method Handles

2021-05-11 Thread Mandy Chung
On 5/11/21 3:14 PM, Remi Forax wrote: Hi Mandy, impressive work ! I think that the method that are a caller-sensitive adapter (the one that takes a supplementary class as last parameter) should be annotated with a specific JDK internal annotation, so the link between the caller sensitive me

Re: Draft JEP: Reimplement Core Reflection on Method Handles

2021-05-11 Thread Mandy Chung
On 5/11/21 2:01 PM, Brian Goetz wrote: Yes, please! To add to the list of motivations/things to remove: the current implementation relies on the special `MagicAccessorImpl` to relax accessibility.  The notes in this class are frightening; getting rid of it would be a mercy. Thanks, gr

Re: Draft JEP: Reimplement Core Reflection on Method Handles

2021-05-11 Thread Remi Forax
Hi Mandy, impressive work ! I think that the method that are a caller-sensitive adapter (the one that takes a supplementary class as last parameter) should be annotated with a specific JDK internal annotation, so the link between the caller sensitive method and it's adapter is obvious for the h

Re: Draft JEP: Reimplement Core Reflection on Method Handles

2021-05-11 Thread Brian Goetz
Yes, please! To add to the list of motivations/things to remove: the current implementation relies on the special `MagicAccessorImpl` to relax accessibility.  The notes in this class are frightening; getting rid of it would be a mercy. On 5/11/2021 4:42 PM, Mandy Chung wrote: This draft JE