Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

2020-08-21 Thread Roger Riggs
Pushed as     8252127: Optimize sun.invoke.util.BytecodeDescriptor.unparse https://bugs.openjdk.java.net/browse/JDK-8252127 Thanks Christoph On 8/20/20 4:15 PM, Roger Riggs wrote: Hi Christoph, Looks good. Note that Claes added the cases for Object.class and int.class to maximize the perform

Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

2020-08-20 Thread Roger Riggs
Hi Christoph, Looks good. Note that Claes added the cases for Object.class and int.class to maximize the performance of those common cases. I'll sponsor the change. Thanks, Roger On 8/20/20 2:01 PM, Christoph Dreis wrote: Hi Roger, thanks for taking a look! Though I wonder if performs di

Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

2020-08-20 Thread Mandy Chung
On 8/20/20 11:01 AM, Christoph Dreis wrote: === PATCH === --- a/src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java Thu Aug 13 09:33:28 2020 -0700 +++ b/src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java Thu Aug 20 19:44:57 202

Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

2020-08-20 Thread Christoph Dreis
Hi Roger, thanks for taking a look! > Though I wonder if performs differently than just calling > t.descriptorString()? Seems pretty much to be the same. The difference of 1 ns for the primitive case is a bit weird, but I guess at this levels it's also possible to have fluctuations here and t

Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

2020-08-20 Thread Roger Riggs
Hi Chris, Inlining and simplifying unparseSig(cl, sb) seems straightforward. Though I wonder if performs differently than just calling t.descriptorString()? The first action of Class.descriptorString is to check for primitives and return the basicTypeString and if not a primitive it calls C

Re: Optimize sun.invoke.util.BytecodeDescriptor.unparse

2020-08-19 Thread Christoph Dreis
HI, I hate pinging, but I would really appreciate it if someone finds the time to take a look at my suggestion below from last week. Or is this maybe the wrong mailing list - given that it is in the "sun" root package? Cheers, Christoph = ORIGINAL MAIL = Hi, I just stumbled upon sun