On Thu, 19 Nov 2020 17:13:00 GMT, Lance Andersen wrote:
>> Small change to retrieve the raw bytes of manifest during verifying signed
>> JAR.
>
> Marked as reviewed by lancea (Reviewer).
Thank you all for the review. I added the noreg-trivial label to the bug.
-
PR: https://git.op
On Thu, 19 Nov 2020 17:20:58 GMT, Hai-May Chao wrote:
>> Marked as reviewed by lancea (Reviewer).
>
> Thank you all for the review. I added the noreg-trivial label to the bug.
Lance, I've entered /integrate. Thank you for sponsoring this!
-
PR: https://git.openjdk.java.net/jdk/pull
On Thu, 19 Nov 2020 17:08:21 GMT, Alan Bateman wrote:
>> Small change to retrieve the raw bytes of manifest during verifying signed
>> JAR.
>
> Marked as reviewed by alanb (Reviewer).
I can sponsor once you integrate
-
PR: https://git.openjdk.java.net/jdk/pull/1299
On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote:
> Small change to retrieve the raw bytes of manifest during verifying signed
> JAR.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1299
On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote:
> Small change to retrieve the raw bytes of manifest during verifying signed
> JAR.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1299
On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote:
> Small change to retrieve the raw bytes of manifest during verifying signed
> JAR.
The changes looks good. I am assuming that we do not need an additional test
for this and if so, please add a noreg label such as noreg-trivial to the bug
On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote:
> Small change to retrieve the raw bytes of manifest during verifying signed
> JAR.
This seems like a good optimization.
I think comparing the manifest name case insensitively might be preferable -
e.g. using String.equalsIgnoreCase - but