Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

2016-11-29 Thread Daniel Fuchs
On 29/11/16 13:33, Wang Weijun wrote: http://cr.openjdk.java.net/~weijun/8170408/webrev.01 jdk_lang passes on all JPRT platforms. Looks good to me Max! best regards, -- daniel Thanks Max On Nov 29, 2016, at 9:26 PM, Daniel Fuchs wrote: Hi Max, On 29/11/16 12:30, Wang Weijun wrote: M

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

2016-11-29 Thread Wang Weijun
http://cr.openjdk.java.net/~weijun/8170408/webrev.01 jdk_lang passes on all JPRT platforms. Thanks Max > On Nov 29, 2016, at 9:26 PM, Daniel Fuchs wrote: > > Hi Max, > > On 29/11/16 12:30, Wang Weijun wrote: >> Maybe I should use >> >> (p, a) -> p.startsWith(Paths.get("dump/com/example")) >>

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

2016-11-29 Thread Daniel Fuchs
Hi Max, On 29/11/16 12:30, Wang Weijun wrote: Maybe I should use (p, a) -> p.startsWith(Paths.get("dump/com/example")) && a.isRegularFile()).count(), Yes - something like that. But that was just a suggestion. On Windows it's \. I remember I had some trouble getting the filter rig

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

2016-11-29 Thread Wang Weijun
Maybe I should use (p, a) -> p.startsWith(Paths.get("dump/com/example")) && a.isRegularFile()).count(), On Windows it's \. I'll run some test now. Thanks Max > On Nov 29, 2016, at 8:25 PM, Wang Weijun wrote: > > Like this? > > (p, a) -> p.toString().startsWith("dump/com/example")

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

2016-11-29 Thread Wang Weijun
Like this? (p, a) -> p.toString().startsWith("dump/com/example") && a.isRegularFile()).count(), Thanks Max > On Nov 29, 2016, at 7:22 PM, Daniel Fuchs wrote: > > Hi Max, > > On 29/11/16 06:46, Wang Weijun wrote: >> http://cr.openjdk.java.net/~weijun/8170408/webrev.00/ >> >> A la

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

2016-11-29 Thread Daniel Fuchs
Hi Max, On 29/11/16 06:46, Wang Weijun wrote: http://cr.openjdk.java.net/~weijun/8170408/webrev.00/ A lambda inside JDK is dumped, we should not count it in this test. Looks good to me. An alternative might be to only look at the files under dump/com/example (I remember modifying LogGenerated