Re: RFR 8251208: Fix javadoc warnings in java.sql and java.sql.rowsets

2020-08-14 Thread Joe Wang
Looks good, Lance. Nothing can't be solved with a cup of coffee ;-) Best, Joe On 8/14/20 10:43 AM, Lance Andersen wrote: Hi Joe, Thank you for the review. Changes had been made to the typos below (went back to far in IntelliJ fixing another issue :-( ) CSR has also been updated to fix the

Re: RFR 8251208: Fix javadoc warnings in java.sql and java.sql.rowsets

2020-08-14 Thread Lance Andersen
Hi Joe, Thank you for the review. Changes had been made to the typos below (went back to far in IntelliJ fixing another issue :-( ) CSR has also been updated to fix the typos (missed I guess due to lack of coffee this am ;-) ) http://cr.openjdk.java.net/~lancea/8251208/webrev.01/index.html is

Re: RFR 8251208: Fix javadoc warnings in java.sql and java.sql.rowsets

2020-08-14 Thread Joe Wang
Hi Lance, Looks good to me overall. * **Minor typos in the CSR:* Address the Fix "no comment" warnings in java.sql and java.sql.rowsetsgenerated by javadoc -Xdoclint     ^ remove Fix  ^ missing a spacebetween rowsetsgenerated java.sql and ja