Re: RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

2014-12-18 Thread Pavel Rappo
Updated webrev: http://cr.openjdk.java.net/~prappo/8067870/webrev.01/ Will push as soon as I see test results. P.S. The thing was lurking there since 28-NOV-2000, ver. 1.106 -Pavel > On 18 Dec 2014, at 14:25, Alan Bateman wrote: > > On 18/12/2014 13:32, Pavel Rappo wrote: >> Hi everyone, >> >

Re: RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

2014-12-18 Thread Alan Bateman
On 18/12/2014 13:32, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8067870? http://cr.openjdk.java.net/~prappo/8067870/webrev.00/ --- I suppose it's the first time this method gets executed.

Re: RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

2014-12-18 Thread roger riggs
Hi Pavel, The change looks ok. But since you're written the test and used it to demonstrate it works, it is useful and with the application of the normal test coding conventions should be added as the regression test for the issue. Thanks, Roger On 12/18/2014 8:32 AM, Pavel Rappo wrote: Hi