Re: Review java.time test refactoring

2013-10-03 Thread Xueming Shen
Looks fine. -Sherman On 10/01/2013 11:53 AM, roger riggs wrote: Ping, needs a Reviewer. http://cr.openjdk.java.net/~rriggs/webrev-serial-refactor-8024896/ Updated the webrev with the renamed test classes to distinguish them from the non-serialization tests in a different package. Thanks, R

Re: Review java.time test refactoring

2013-10-01 Thread roger riggs
Ping, needs a Reviewer. http://cr.openjdk.java.net/~rriggs/webrev-serial-refactor-8024896/ Updated the webrev with the renamed test classes to distinguish them from the non-serialization tests in a different package. Thanks, Roger On 9/23/2013 11:04 AM, Stephen Colebourne wrote: The chang

Re: Review java.time test refactoring

2013-09-23 Thread Stephen Colebourne
The change looks fine AFAICT. I would prefer to see the new serial package test classes have names that end in "Serialization", eg "TCKLocalDateSerialization", but if that does not happen it is not the end of the world. Stephen On 18 September 2013 22:31, roger riggs wrote: > A review of the TCK