Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-26 Thread joe . darcy
Hi Ulf. On 9/23/2011 2:14 AM, Ulf Zibis wrote: Am 23.09.2011 01:29, schrieb Joe Darcy: On 9/22/2011 2:07 PM, Ulf Zibis wrote: Am 22.09.2011 19:18, schrieb Ulf Zibis: I'm wondering why you don't have moved concerning documentation from sun.misc.* to java.lang.(Strict)Math. E.G.: The comment on

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-23 Thread Ulf Zibis
Am 23.09.2011 01:29, schrieb Joe Darcy: On 9/22/2011 2:07 PM, Ulf Zibis wrote: Am 22.09.2011 19:18, schrieb Ulf Zibis: I'm wondering why you don't have moved concerning documentation from sun.misc.* to java.lang.(Strict)Math. E.G.: The comment on the scalb operations: /* * The scalb operation

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-22 Thread Joe Darcy
On 9/22/2011 2:07 PM, Ulf Zibis wrote: Am 22.09.2011 19:18, schrieb Ulf Zibis: I'm wondering why you don't have moved concerning documentation from sun.misc.* to java.lang.(Strict)Math. E.G.: The comment on the scalb operations: /* * The scalb operation should be reasonable ... */ To save s

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-22 Thread Ulf Zibis
Am 22.09.2011 19:18, schrieb Ulf Zibis: I'm wondering why you don't have moved concerning documentation from sun.misc.* to java.lang.(Strict)Math. E.G.: The comment on the scalb operations: /* * The scalb operation should be reasonable ... */ To save some source code footprint and allow bette

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-22 Thread Ulf Zibis
I'm wondering why you don't have moved concerning documentation from sun.misc.* to java.lang.(Strict)Math. E.G.: The comment on the scalb operations: /* * The scalb operation should be reasonable ... */ To save some source code footprint and allow better overview, I suggest to erase all javado

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-19 Thread Ulf Zibis
Without a deeper look, I discovered several ternary operators without spacing. For better readability, it would be nice to insert some spaces. :-) -Ulf Am 17.09.2011 03:52, schrieb joe.da...@oracle.com: Hello. Please review the changes to address 7091682 "Move sun.misc.FpUtils code into j

Re: Re : JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-19 Thread Joe Darcy
PS I've added your comment to bug 6667086 "Double.doubleToLongBits(final double value) contains inefficient test for NaN." -Joe On 9/18/2011 6:15 PM, Joe Darcy wrote: Hi Jeff. I'll consider that for some possible future work. Thanks, -Joe Jeff Hain wrote: Hi. There are some possible optim

Re: Re : JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-18 Thread Joe Darcy
Hi Jeff. I'll consider that for some possible future work. Thanks, -Joe Jeff Hain wrote: Hi. There are some possible optimizations for some methods. For nextAfter(double,double) (same for float version), instead of testing NaN-ity right away, we can test most common (or at least regular) c

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-18 Thread Joe Darcy
Alan Bateman wrote: joe.da...@oracle.com wrote: Hello. Please review the changes to address 7091682 "Move sun.misc.FpUtils code into java.lang.Math" http://cr.openjdk.java.net/~darcy/7091682.0/ As implied by the synopsis, where appropriate JDK-implementation code used to provide functi

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-18 Thread Joe Darcy
Mike Duigou wrote: I am curious why some of the tests still refer to FpUtils. For example: Log10Tests.java: 156 up = Math.nextUp(1.0); 157 down = FpUtils.nextDown(1.0); Would it be possible to further reduce or eliminate the references to FpUtils fro

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-18 Thread Mike Duigou
I am curious why some of the tests still refer to FpUtils. For example: Log10Tests.java: 156 up = Math.nextUp(1.0); 157 down = FpUtils.nextDown(1.0); Would it be possible to further reduce or eliminate the references to FpUtils from the tests? Mike O

Re : JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-17 Thread Jeff Hain
Hi. There are some possible optimizations for some methods. For nextAfter(double,double) (same for float version), instead of testing NaN-ity right away, we can test most common (or at least regular) cases first: public static double nextAfter(double start, double direction) {     // Balancin

Re: JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

2011-09-17 Thread Alan Bateman
joe.da...@oracle.com wrote: Hello. Please review the changes to address 7091682 "Move sun.misc.FpUtils code into java.lang.Math" http://cr.openjdk.java.net/~darcy/7091682.0/ As implied by the synopsis, where appropriate JDK-implementation code used to provide functionality in java.lang.