This patch looks okay to me.
Mandy
On 8/23/19 8:44 AM, Roger Riggs wrote:
Hi Philippe,
The change looks good, I'll run it through our tests and push if its
all ok.
(Pending anyone else's comments.)
On 8/23/19 10:38 AM, Philippe Marschall wrote:
On 22.08.19 19:56, Mandy Chung wrote:
Hi
Hi Philippe,
The change looks good, I'll run it through our tests and push if its all ok.
(Pending anyone else's comments.)
On 8/23/19 10:38 AM, Philippe Marschall wrote:
On 22.08.19 19:56, Mandy Chung wrote:
Hi Philippe,
This is a good use of StackWalker. getSource can simply return
On 22.08.19 19:56, Mandy Chung wrote:
Hi Philippe,
This is a good use of StackWalker. getSource can simply return
StackFrame and avoid the creation of String[].
Updated webrev [1] and inline diff at the end.
Something I noted is that we could replace
Hi Philippe,
I'll be happy to sponsor the fix.
Mandy's suggestion makes sense to me, please update the patch.
I filed https://bugs.openjdk.java.net/browse/JDK-8230058 to track the
change.
Regards, Roger
On 8/22/19 1:56 PM, Mandy Chung wrote:
Hi Philippe,
This is a good use of
Hi Philippe,
This is a good use of StackWalker. getSource can simply return
StackFrame and avoid the creation of String[].
Stuart will give you better guidance related to RMI testing.
I see that test/jdk/sun/rmi/runtime/Log has a few RMI logging tests.
RMI tests are in tier3. You can run
Hello
First time contributor here.
We have exception tracing enabled in production and see thousands of
exceptions in sun.rmi.runtime.Log#getSource() to get the caller class.
In my option this should use StackWalker introduced in Java 9. I could
find no corresponding bug in JBS.
I created a
